Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Why callback is called by setImmediate? #8

Open
behrad opened this issue Jun 5, 2018 · 1 comment
Open

Why callback is called by setImmediate? #8

behrad opened this issue Jun 5, 2018 · 1 comment

Comments

@behrad
Copy link
Contributor

behrad commented Jun 5, 2018

mqemitter-redis/mqemitter-redis.js

Line 104 in da684f3

setImmediate(done)

Why not calling done normally inside the finished callback?
@mcollina
Copy link
Owner

mcollina commented Jun 6, 2018

I do not remember. Would you like to fix this?

behrad added a commit to behrad/mqemitter-redis that referenced this issue Jun 6, 2018
@behrad
switch shortid to hyperid for performance (fixes mcollina#7) & remove…
4062f69 
… setImmediates (fixes mcollina#8)
@behrad behrad mentioned this issue Jun 6, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mcollina @behrad