Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace shortid via hyperid for performance reasons? #7

Closed
behrad opened this issue Jun 5, 2018 · 3 comments
Closed

Replace shortid via hyperid for performance reasons? #7

behrad opened this issue Jun 5, 2018 · 3 comments

Comments

@behrad
Copy link
Contributor

behrad commented Jun 5, 2018

mqemitter-redis/mqemitter-redis.js

Line 133 in da684f3

id: shortid(),

@mcollina
Copy link
Owner

mcollina commented Jun 5, 2018

definitely! PR?

@behrad
Copy link
Contributor Author

behrad commented Jun 5, 2018

PR?

sure 👍

behrad added a commit to behrad/mqemitter-redis that referenced this issue Jun 6, 2018
@behrad
switch shortid to hyperid for performance (fixes mcollina#7) & remove…
4062f69 
… setImmediates (fixes mcollina#8)
@behrad behrad mentioned this issue Jun 6, 2018
Closed
@kibertoad
Copy link
Contributor

This can be closed now that #11 was merged

@mcollina mcollina closed this as completed May 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@mcollina @kibertoad @behrad