Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename au921 to au915 #470

Merged
merged 4 commits into from
Dec 31, 2019
Merged

Conversation

frazar
Copy link

@frazar frazar commented Oct 5, 2019

Closes #363

Currently it fails in CI because, for the MCCI Catena's BSP, the lorawan_region parameter is named au921, not au915.

The error is the following:

$ _notstm32l0 ||  arduino --verify --board $(_stm32l0opts '' au915  ) $MCCI_STM32_OPTS $PWD/examples/raw-feather/raw-feather.ino

Picked up JAVA_TOOL_OPTIONS: 
Loading configuration...
Initializing packages...
Preparing boards...
Error: au915: Invalid value for option "lorawan_region" for board "mcci_catena_4551"
The command "_notstm32l0 ||  arduino --verify --board $(_stm32l0opts '' au915  ) $MCCI_STM32_OPTS $PWD/examples/raw-feather/raw-feather.ino" exited with 3.

It should be fixed if mcci-catena/ArduinoCore-samd#37 is merged.

@terrillmoore
Copy link
Member

Ah, sorry, and thanks for this.

I want to make sure I understand: are you expecting the CI build to fail for this even after the patch?

I think it might be a good idea to have some transitional code.

If there's no CFG_* defined in the "standard" set, then check CFG_au921. If it's defined, define CFG_au915, and go on; otherwise define CFG_eu866 as at present. Would that allow us to work either way, transitionally?

@frazar
Copy link
Author

frazar commented Oct 8, 2019

To clarify, this should work after mcci-catena/ArduinoCore-samd#37 is merged.
It fails only beacuse it passes the value "au915" for the parameter "lorawan_region" of the BSP. Since as of now the BSP is (mistakenly) naming the configuration "au921", it fails.

@frazar frazar force-pushed the rename_AU921_to_AU915 branch from 458d1f7 to 68d8aff Compare November 10, 2019 11:07
@terrillmoore terrillmoore merged commit 3ca90f3 into mcci-catena:master Dec 31, 2019
@frazar frazar deleted the rename_AU921_to_AU915 branch February 14, 2020 17:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rename AU921 -> AU915
2 participants