Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename AU921 -> AU915 #363

Closed
terrillmoore opened this issue Aug 14, 2019 · 1 comment · Fixed by #470
Closed

Rename AU921 -> AU915 #363

terrillmoore opened this issue Aug 14, 2019 · 1 comment · Fixed by #470
Assignees
@terrillmoore
Labels
bug docs enhancement

Comments

@terrillmoore
Copy link
Member

Per @paulalting #340:

We all here in Australia call our band AU915, not AU921.

Rename CFG_au921 to CFG_au915, and do the required in all the subordinate locations. Allow CFG_au921 to imply CFG_au915 with a warning.
@terrillmoore terrillmoore self-assigned this Aug 14, 2019
@terrillmoore terrillmoore mentioned this issue Aug 15, 2019
Closed
@Scobber
Copy link

Scobber commented Aug 15, 2019

I concur. it appears to be named incorrectly.

AU_923 is not a thing.
The formal band names in use here in Australia are AU_915 and AS_921, and the latter is supposed to support the equivalent of 923 as a sub band.

This was referenced Oct 5, 2019
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@terrillmoore terrillmoore

Labels
bug docs enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Rename au921 to au915 frazar/arduino-lmic
2 participants
@Scobber @terrillmoore