Add AU915 plan & setting #341
Conversation
|
AVR fails CI. We also need documentation to explain why this is needed, etc. Updates to README.md. Aslso see comments on commit it looks like some things have regressed. |
| @@ -421,6 +468,7 @@ enum { | |||
| HDR_FTYPE_DADN = 0x60, // data (unconfirmed) dn | |||
| HDR_FTYPE_DCUP = 0x80, // data confirmed up | |||
| HDR_FTYPE_DCDN = 0xA0, // data confirmed dn | |||
| HDR_FTYPE_REJOIN = 0xC0, // rejoin for roaming | |||
There was a problem hiding this comment.
This is a regression, as it's not part of the LoRaWAN 1.0.3 spec. Please remove.
There was a problem hiding this comment.
sorry this might have been an oversight on making the device work.
| @@ -64,6 +64,7 @@ Revision history: | |||
| // constants for comparison | |||
| #define LMIC_REGION_eu868 1 | |||
| #define LMIC_REGION_us915 2 | |||
| #define LMIC_REGION_au915 2 | |||
There was a problem hiding this comment.
This should be a unique value. By convention, these match the subsections in the LoRaWAN regional spec.I've not had a chance to review the updates that enable AU915. Because the regulatory regime is different, even if this is identical to US915, we need to think about keeping it separate here. (There's no necessary connection, it's just an interesting fact.)
There was a problem hiding this comment.
Its the same band per se, the US ISM actually starts lower.
so we are not able to use the first sub band,
One other difference is the use of EIRP here.
There was a problem hiding this comment.
@Scobber What document defines AU915 (as opposed to "AU915-928", which is defined by section 2.6 of the LoRaWAN regional parameters document)?
This is important because we (architecturally) must use a new value for LMIC_REGION_au915 -- we can't use 2 because it's already in use. I just checked the latest regional specs, and this doesn't seem to be published. Is this something the LoRa Alliance defined, or something someone else defined? Thanks!
| @@ -1,6 +1,7 @@ | |||
| // project-specific definitions | |||
| //#define CFG_eu868 1 | |||
| #define CFG_us915 1 | |||
| #define CFG_au915 1 | |||
There was a problem hiding this comment.
we shouldn't change this in lmic_project_config.h, I think.
There was a problem hiding this comment.
yeah i agree, i committed what i use here. i probably should have sent //#define CGG_au915 instead
Add band plan and defines that enable AU915