Skip to content
This repository has been archived by the owner on May 5, 2023. It is now read-only.

Update ReactDOM import #522

Merged
merged 1 commit into from
Jul 25, 2019
Merged

Update ReactDOM import #522

merged 1 commit into from
Jul 25, 2019

Conversation

mcansh
Copy link
Owner

@mcansh mcansh commented Jul 25, 2019

No description provided.

@mcansh mcansh added the automerge Have Kodiak automerge the PR label Jul 25, 2019
@mcansh mcansh self-assigned this Jul 25, 2019
@chdsbd chdsbd mentioned this pull request Jul 25, 2019
Closed
@chdsbd
Copy link

chdsbd commented Jul 25, 2019

I discovered that it's not possible for Kodiak to work with the "Require signed commits" branch protection feature because merging a PR through Github's API doesn't have a signature attached, so Github blocks the merge.

@codecov
Copy link

codecov bot commented Jul 25, 2019 •
edited
Loading

Codecov Report

Merging #522 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master    #522   +/-   ##
======================================
  Coverage    48.1%   48.1%           
======================================
  Files          11      11           
  Lines          79      79           
  Branches       21      21           
======================================
  Hits           38      38           
  Misses         41      41

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c30f6fe...229c49b. Read the comment docs.

11 similar comments
@codecov
Copy link

codecov bot commented Jul 25, 2019 •
edited
Loading

Codecov Report

Merging #522 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master    #522   +/-   ##
======================================
  Coverage    48.1%   48.1%           
======================================
  Files          11      11           
  Lines          79      79           
  Branches       21      21           
======================================
  Hits           38      38           
  Misses         41      41

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c30f6fe...229c49b. Read the comment docs.

@codecov
Copy link

codecov bot commented Jul 25, 2019 •
edited
Loading

Codecov Report

Merging #522 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master    #522   +/-   ##
======================================
  Coverage    48.1%   48.1%           
======================================
  Files          11      11           
  Lines          79      79           
  Branches       21      21           
======================================
  Hits           38      38           
  Misses         41      41

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c30f6fe...229c49b. Read the comment docs.

@codecov
Copy link

codecov bot commented Jul 25, 2019 •
edited
Loading

Codecov Report

Merging #522 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master    #522   +/-   ##
======================================
  Coverage    48.1%   48.1%           
======================================
  Files          11      11           
  Lines          79      79           
  Branches       21      21           
======================================
  Hits           38      38           
  Misses         41      41

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c30f6fe...229c49b. Read the comment docs.

@codecov
Copy link

codecov bot commented Jul 25, 2019 •
edited
Loading

Codecov Report

Merging #522 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master    #522   +/-   ##
======================================
  Coverage    48.1%   48.1%           
======================================
  Files          11      11           
  Lines          79      79           
  Branches       21      21           
======================================
  Hits           38      38           
  Misses         41      41

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c30f6fe...229c49b. Read the comment docs.

@codecov
Copy link

codecov bot commented Jul 25, 2019

Codecov Report

Merging #522 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master    #522   +/-   ##
======================================
  Coverage    48.1%   48.1%           
======================================
  Files          11      11           
  Lines          79      79           
  Branches       21      21           
======================================
  Hits           38      38           
  Misses         41      41

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c30f6fe...229c49b. Read the comment docs.

@codecov
Copy link

codecov bot commented Jul 25, 2019

Codecov Report

Merging #522 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master    #522   +/-   ##
======================================
  Coverage    48.1%   48.1%           
======================================
  Files          11      11           
  Lines          79      79           
  Branches       21      21           
======================================
  Hits           38      38           
  Misses         41      41

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c30f6fe...229c49b. Read the comment docs.

@codecov
Copy link

codecov bot commented Jul 25, 2019 •
edited
Loading

Codecov Report

Merging #522 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master    #522   +/-   ##
======================================
  Coverage    48.1%   48.1%           
======================================
  Files          11      11           
  Lines          79      79           
  Branches       21      21           
======================================
  Hits           38      38           
  Misses         41      41

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c30f6fe...229c49b. Read the comment docs.

@codecov
Copy link

codecov bot commented Jul 25, 2019 •
edited
Loading

Codecov Report

Merging #522 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master    #522   +/-   ##
======================================
  Coverage    48.1%   48.1%           
======================================
  Files          11      11           
  Lines          79      79           
  Branches       21      21           
======================================
  Hits           38      38           
  Misses         41      41

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c30f6fe...229c49b. Read the comment docs.

@codecov
Copy link

codecov bot commented Jul 25, 2019 •
edited
Loading

Codecov Report

Merging #522 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master    #522   +/-   ##
======================================
  Coverage    48.1%   48.1%           
======================================
  Files          11      11           
  Lines          79      79           
  Branches       21      21           
======================================
  Hits           38      38           
  Misses         41      41

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c30f6fe...229c49b. Read the comment docs.

@codecov
Copy link

codecov bot commented Jul 25, 2019 •
edited
Loading

Codecov Report

Merging #522 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master    #522   +/-   ##
======================================
  Coverage    48.1%   48.1%           
======================================
  Files          11      11           
  Lines          79      79           
  Branches       21      21           
======================================
  Hits           38      38           
  Misses         41      41

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c30f6fe...229c49b. Read the comment docs.

@codecov
Copy link

codecov bot commented Jul 25, 2019 •
edited
Loading

Codecov Report

Merging #522 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master    #522   +/-   ##
======================================
  Coverage    48.1%   48.1%           
======================================
  Files          11      11           
  Lines          79      79           
  Branches       21      21           
======================================
  Hits           38      38           
  Misses         41      41

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c30f6fe...229c49b. Read the comment docs.

@mcansh mcansh added automerge Have Kodiak automerge the PR and removed automerge Have Kodiak automerge the PR labels Jul 25, 2019
@kodiakhq kodiakhq bot merged commit 5acea6e into master Jul 25, 2019
@kodiakhq kodiakhq bot deleted the mcansh-patch-1 branch July 25, 2019 12:16
@mcansh
Copy link
Owner Author

mcansh commented Jul 25, 2019

I discovered that it's not possible for Kodiak to work with the "Require signed commits" branch protection feature because merging a PR through Github's API doesn't have a signature attached, so Github blocks the merge.

Yep that seems to have fixed it, thanks!

kodiakhq bot pushed a commit that referenced this pull request Nov 5, 2019
@dependabot-preview @kodiakhq
chore(deps-dev): bump @testing-library/react from 9.3.1 to 9.3.2 (#594)
62799cd 
Bumps [@testing-library/react](https://github.com/testing-library/react-testing-library) from 9.3.1 to 9.3.2.
<details>
<summary>Release notes</summary>

*Sourced from [@testing-library/react's releases](https://github.com/testing-library/react-testing-library/releases).*

> ## v9.3.2
> ## [9.3.2](testing-library/react-testing-library@v9.3.1...v9.3.2) (2019-11-04)
> 
> 
> ### Bug Fixes
> 
> * False positive warning about MessageChannel ([#522](https://github-redirect.dependabot.com/testing-library/react-testing-library/issues/522)) ([11460a3](testing-library/react-testing-library@11460a3))
</details>
<details>
<summary>Commits</summary>

- [`11460a3`](testing-library/react-testing-library@11460a3) fix: False positive warning about MessageChannel ([#522](https://github-redirect.dependabot.com/testing-library/react-testing-library/issues/522))
- See full diff in [compare view](testing-library/react-testing-library@v9.3.1...v9.3.2)
</details>
<br />

[![Dependabot compatibility score](https://api.dependabot.com/badges/compatibility_score?dependency-name=@testing-library/react&package-manager=npm_and_yarn&previous-version=9.3.1&new-version=9.3.2)](https://dependabot.com/compatibility-score.html?dependency-name=@testing-library/react&package-manager=npm_and_yarn&previous-version=9.3.1&new-version=9.3.2)

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`.

[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)

---

<details>
<summary>Dependabot commands and options</summary>
<br />

You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge and block automerging
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
- `@dependabot badge me` will comment on this PR with code to add a "Dependabot enabled" badge to your readme

Additionally, you can set the following in the `.dependabot/config.yml` file in this repo:
- Update frequency
- Out-of-range updates (receive only lockfile updates, if desired)
- Security updates (receive only security updates, if desired)



</details>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees

@mcansh mcansh

Labels
automerge Have Kodiak automerge the PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mcansh @chdsbd