Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bot not updating PR #83

Closed
Timer opened this issue Jul 25, 2019 · 9 comments
Closed

Bot not updating PR #83

Timer opened this issue Jul 25, 2019 · 9 comments
Labels
bug Something isn't working

Comments

@Timer
Copy link

Timer commented Jul 25, 2019 •
edited
Loading

It seems the bot is not updating the PR with the latest changes from the canary branch (the default GH branch).

vercel/next.js#7704

It's stuck as:

kodiakhq: status — ⛴ attempting to merge PR (updating branch)

The optimistic_updates is set to true, FWIW.
Also using the new require_automerge_label = false option if it matters.
@chdsbd
Copy link
Owner

chdsbd commented Jul 25, 2019

I think it's waiting on the tests to pass, but I'm not sure. Let me dig into this a bit.

@chdsbd
Copy link
Owner

chdsbd commented Jul 25, 2019

It seems odd that it's trying to merge with that required status check not passing.

@sbdchd sbdchd added the bug Something isn't working label Jul 25, 2019
@Timer
Copy link
Author

Timer commented Jul 25, 2019

I had to disable the bot now per #84, but yeah not sure what's going on. 🤔

@Timer Timer mentioned this issue Jul 25, 2019
Closed
@chdsbd
Copy link
Owner

chdsbd commented Jul 25, 2019

I'm going to look into reproducing this more, but my first suspicion is that this may have been from the deploy.

@chdsbd
Copy link
Owner

chdsbd commented Jul 25, 2019

Related, kodiak thinks this PR is okay to merge, but when it attempts to merge it, it gets an error from the Github API, which we don't log in detail, so I'm not sure what it is.

chdsbd added a commit that referenced this issue Jul 25, 2019
@chdsbd
hotfix: add logging to help debug errors
6579ca3 
Kodiak and Github appear to have different opinions on what a mergeable
PR is in some cases. This change adds some logging to help us discover
why.

Related #83
@chdsbd chdsbd mentioned this issue Jul 25, 2019
Merged
kodiakhq bot pushed a commit that referenced this issue Jul 25, 2019
@chdsbd @kodiakhq
hotfix: add logging to help debug errors (#85)
d2617cc 
Kodiak and Github appear to have different opinions on what a mergeable
PR is in some cases. This change adds some logging to help us discover
why.

Related #83
@chdsbd
Copy link
Owner

chdsbd commented Jul 25, 2019

@Timer Does this branch use the same branch protection as #84 (comment)?

@Timer
Copy link
Author

Timer commented Jul 25, 2019

Yes!

@chdsbd
Copy link
Owner

chdsbd commented Jul 25, 2019

I've tested with the following config and I haven't been able to reproduce the issue.

Screen Shot 2019-07-24 at 11 54 15 PM

I've added some more detailed logging so hopefully we'll be able to better debug any issues that pop up.

Please reopen this ticket if this issue occurs again.

@chdsbd chdsbd closed this as completed Jul 25, 2019
@Timer
Copy link
Author

Timer commented Jul 25, 2019

Great, will reenable the bot and report back.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@Timer @chdsbd @sbdchd