Revert repeat includes #411
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'll be happy to look further into the matter mentioned in 57fc9a9 of updating the macro hooks everywhere else that the change may be needed, when I have some more time to see if there is missing coverage, etc. The Rails 4 build errors on Travis for this changeset should be resolved by #410, looks like Rails 4 has removed internal use of |
This reverts commit e44b69d. This undid the work of 16c4567 such that we were now re-including most the library on subsequent calls of the macro method like: acts_as_taggable_on :pros acts_as_taggable_on :cons The change was made in order to fix dirty tracking on mbleigh#321, but the proper fix is that the dirty tracking module is missing a hook `acts_as_taggable_on` macro that calls super.
Following b9b2747, a spec broke for related when ordered tags are in use, since the hook for repeated calls of the macro was not maintaining the preserve order value. This hook pattern likely needs to be updated throughout the library now that the `acts_as_ordered_taggable_on` exists as an alternative macro, but I'm just fixing what broke a spec within the scope of my current branch.
|
Rebased since unrelated build problems have been fixed since this originated. |
|
I'll get to it... |
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale is given, with references, in the extended commit messages on this branch.