Fix dirty checking for subsequent calls to taggable_on. Fixes #321. #339
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Related mbleigh#321. Split tests for single-assertions
Don't include Utils multiple times
|
Alright, I'm good to go on this PR. |
tilsammans
added a commit
that referenced
this pull request
Apr 14, 2013
Fix dirty checking for subsequent calls to taggable_on. Fixes #321.
|
Thank you very much, it looks good to me. This will come along with the 2.5.0 version of the gem. (2.4.0 will be out in a few days) |
ches
added a commit
to ches/acts-as-taggable-on
that referenced
this pull request
Sep 26, 2013
ches
added a commit
to ches/acts-as-taggable-on
that referenced
this pull request
Dec 10, 2013
tekniklr
pushed a commit
to tekniklr/acts-as-taggable-on
that referenced
this pull request
Mar 19, 2021
Fix dirty checking for subsequent calls to taggable_on. Fixes mbleigh#321.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It was discovered that the dirty module was not being called on tags within a context. I added the specs to detect the issue (and cleaned up others for single-assertion testing for better coverage).
It turns out that all of the include calls were happening only the first time
acts_as_taggable_onwas being called, and all subsequent calls ignored those includes, despite the context-specific actions that happen when those modules are included.I'm not sure, but there may be other issues related to non-default contexts that may be resolved by this.
I'll go through and double check that each of these includes are required every time we add taggable types and notify you if any other changes need to be made before this is pulled in.