Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

💄 [#2029] Set new default open-source font #986

Merged
merged 2 commits into from
Jan 30, 2024

Conversation

jiromaykin
Copy link
Contributor

@jiromaykin jiromaykin commented Jan 23, 2024

Issue:

  1. Set Ubuntu as heading font and Lato as body font: https://taiga.maykinmedia.nl/project/open-inwoner/task/2029
  2. also needs this change in font variable name in this Design-token package PR: [#2029] Set default heading font-family as Heading open-inwoner-design-tokens#6

This PR only works when you check out the corresponding branch of this PR and run NPM build on both repositories.

Preview styling here: http://localhost:8000/style-demo/

@codecov-commenter
Copy link

codecov-commenter commented Jan 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (e3d539f) 94.76% compared to head (bc58d1c) 94.76%.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop     #986   +/-   ##
========================================
  Coverage    94.76%   94.76%           
========================================
  Files          861      861           
  Lines        30202    30202           
========================================
  Hits         28620    28620           
  Misses        1582     1582           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jiromaykin jiromaykin force-pushed the feature/2029-new-default-open-source-font branch from 47e205d to bc58d1c Compare January 23, 2024 16:43
@jiromaykin jiromaykin marked this pull request as ready for review January 23, 2024 16:44
@jiromaykin jiromaykin force-pushed the feature/2029-new-default-open-source-font branch from e788897 to 1441520 Compare January 23, 2024 18:08
@jiromaykin jiromaykin requested a review from pi-sigma January 23, 2024 18:45
@font-face {
font-family: 'Body';
font-style: italic;
src: url('/static/fonts/lato/Lato-Italic.ttf') format('truetype');
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pi-sigma Around here I am specifying separate font-files for the regular/bol/Italic/bold-italic situations, since that is the official way to prevent so-called "faux-rendering" but... I am not sure what effect this will have on your PR #963

@jiromaykin jiromaykin force-pushed the feature/2029-new-default-open-source-font branch from d34f264 to e56c325 Compare January 30, 2024 09:15
@pi-sigma
Copy link
Contributor

pi-sigma commented Jan 30, 2024

From Mijn profiel:

  • The "Mijn vragen" card looks a little squished, distance between title and text could be greater (though that was also the case with the previous font)

Screenshot from 2024-01-30 10-18-23

The new font looks very light to me; perhaps it just takes some getting used to...

@jiromaykin
Copy link
Contributor Author

From Mijn profiel: * The "Mijn vragen" card looks a little squished

Ah, @pi-sigma that is not because of the font, but because of the way the grid works: if there is only one card in a row it becomes very small (a different issue, not related to Font).

@alextreme alextreme merged commit 3eac1e1 into develop Jan 30, 2024
14 checks passed
@alextreme alextreme deleted the feature/2029-new-default-open-source-font branch January 30, 2024 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants