Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

💄 [#1905] Set Roboto as standard font statically #885

Closed
wants to merge 1 commit into from

Conversation

jiromaykin
Copy link
Contributor

@jiromaykin jiromaykin commented Dec 7, 2023

Replacing 'The Sans' and 'The Mix' with another font since our current fonts are not open-source: https://taiga.maykinmedia.nl/project/open-inwoner/task/1905

To see new font in action: completely empty all your browsers' caches.

Preview for some pages with Roboto:
Uploading Roboto-preview.pdf…

This is on hold for now since we're looking for different open-source fonts (probably not Roboto): https://taiga.maykinmedia.nl/project/open-inwoner/us/2021

@jiromaykin jiromaykin force-pushed the feature/1905-set-roboto-as-default-font branch from acfb736 to 76babe8 Compare December 7, 2023 16:49
@codecov-commenter
Copy link

codecov-commenter commented Dec 7, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (802433f) 92.81% compared to head (76babe8) 92.81%.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop     #885   +/-   ##
========================================
  Coverage    92.81%   92.81%           
========================================
  Files          802      802           
  Lines        27525    27525           
========================================
  Hits         25547    25547           
  Misses        1978     1978           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jiromaykin jiromaykin force-pushed the feature/1905-set-roboto-as-default-font branch 2 times, most recently from 1330ca9 to 80847a8 Compare December 11, 2023 08:44
@alextreme
Copy link
Member

@jiromaykin jiromaykin force-pushed the feature/1905-set-roboto-as-default-font branch from fa43751 to 4759e88 Compare December 11, 2023 12:55
@jiromaykin jiromaykin marked this pull request as ready for review December 11, 2023 12:56
@jiromaykin jiromaykin marked this pull request as draft December 19, 2023 11:17
@jiromaykin jiromaykin added the wip Work in progress label Dec 21, 2023
@jiromaykin jiromaykin force-pushed the feature/1905-set-roboto-as-default-font branch from 4759e88 to f3b9491 Compare January 15, 2024 14:19
@jiromaykin jiromaykin removed the wip Work in progress label Jan 23, 2024
@jiromaykin
Copy link
Contributor Author

Obsolete because of different default font #986

@jiromaykin jiromaykin closed this Jan 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants