Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🌐 [#2022] Update translations january 2024 #955

Merged
merged 2 commits into from
Jan 16, 2024

Conversation

jiromaykin
Copy link
Contributor

@jiromaykin jiromaykin marked this pull request as ready for review January 15, 2024 15:49
@jiromaykin
Copy link
Contributor Author

@alextreme probleempje: er zit een spelfout in deze migration "...al uw lopende AN afgeronde aanvragen" - daar moet dan een nieuwe migration voor gemaakt worden? (kan vast niet alleen handmatig worden aangepast?) https://github.com/maykinmedia/open-inwoner/blob/develop/src/open_inwoner/openzaak/migrations/0025_openzaakconfig_title_text.py

@jiromaykin jiromaykin force-pushed the issue/2022-update-translations-sprint-18 branch from e3fceef to 3a062dc Compare January 15, 2024 16:21
@codecov-commenter
Copy link

codecov-commenter commented Jan 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (ba38b08) 94.68% compared to head (be9d67c) 94.68%.

❗ Current head be9d67c differs from pull request most recent head e280f54. Consider uploading reports for the commit e280f54 to get more accurate results

Additional details and impacted files
@@           Coverage Diff            @@
##           develop     #955   +/-   ##
========================================
  Coverage    94.68%   94.68%           
========================================
  Files          831      831           
  Lines        29275    29275           
========================================
  Hits         27720    27720           
  Misses        1555     1555           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jiromaykin jiromaykin requested a review from alextreme January 16, 2024 09:10
alextreme added a commit that referenced this pull request Jan 16, 2024
@alextreme
Copy link
Member

@alextreme probleempje: er zit een spelfout in deze migration "...al uw lopende AN afgeronde aanvragen" - daar moet dan een nieuwe migration voor gemaakt worden? (kan vast niet alleen handmatig worden aangepast?) https://github.com/maykinmedia/open-inwoner/blob/develop/src/open_inwoner/openzaak/migrations/0025_openzaakconfig_title_text.py

Bij deze gefixed in develop en in v1.12.8, dat scheelt weer oplossen op elke productieomgeving dank!

@jiromaykin jiromaykin marked this pull request as draft January 16, 2024 13:18
@jiromaykin jiromaykin force-pushed the issue/2022-update-translations-sprint-18 branch from 3a062dc to bbe50fa Compare January 16, 2024 13:19
@jiromaykin jiromaykin force-pushed the issue/2022-update-translations-sprint-18 branch from be9d67c to e280f54 Compare January 16, 2024 13:25
@jiromaykin jiromaykin marked this pull request as ready for review January 16, 2024 13:27
Copy link
Member

@alextreme alextreme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nog 2 vertalingen toegevoegd maar verder in orde, dank hiervoor!

@alextreme alextreme merged commit f1a566e into develop Jan 16, 2024
12 checks passed
@alextreme alextreme deleted the issue/2022-update-translations-sprint-18 branch January 16, 2024 20:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants