Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/has geometry #72

Merged
merged 6 commits into from
Dec 3, 2021
Merged

Feature/has geometry #72

merged 6 commits into from
Dec 3, 2021

Conversation

annashamray
Copy link
Collaborator

Copy link
Member

@joeribekker joeribekker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, it feels a little brittle. Can you still create objects with geo in the objects API even if hasGeo is false in the objecttype?

This should be checked! And, we should document in the API spec what happens if you set hasGeo to true/false, and also document it in the objects api that creating an object can error because of it.

@annashamray
Copy link
Collaborator Author

@joeribekker I've updated the description of the field in the schema
And I also created the check in the Objects API, which prevents adding geometry if the related objecttype doesn't allow it - maykinmedia/objects-api#265

@annashamray
Copy link
Collaborator Author

as discussed with @joeribekker hasGeometry field was renamed to canHaveGeometry

@annashamray annashamray merged commit 824db5d into master Dec 3, 2021
@annashamray annashamray deleted the feature/has-geometry branch December 3, 2021 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants