Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/hasgeometry check #265

Merged
merged 6 commits into from
Dec 3, 2021
Merged

Feature/hasgeometry check #265

merged 6 commits into from
Dec 3, 2021

Conversation

annashamray
Copy link
Collaborator

@annashamray annashamray commented Nov 26, 2021

@codecov-commenter
Copy link

codecov-commenter commented Nov 26, 2021

Codecov Report

Merging #265 (c7eb0ee) into master (c08221d) will increase coverage by 0.06%.
The diff coverage is 97.29%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #265      +/-   ##
==========================================
+ Coverage   93.98%   94.05%   +0.06%     
==========================================
  Files         124      125       +1     
  Lines        4093     4191      +98     
==========================================
+ Hits         3847     3942      +95     
- Misses        246      249       +3     
Impacted Files Coverage Δ
src/objects/core/models.py 84.28% <ø> (ø)
src/objects/api/validators.py 92.64% <85.00%> (-3.19%) ⬇️
src/objects/api/serializers.py 100.00% <100.00%> (ø)
...objects/core/migrations/0027_auto_20211126_1725.py 100.00% <100.00%> (ø)
src/objects/tests/utils.py 100.00% <100.00%> (ø)
src/objects/tests/v1/test_notifications_send.py 100.00% <100.00%> (ø)
src/objects/tests/v1/test_object_api.py 100.00% <100.00%> (ø)
src/objects/tests/v1/test_validation.py 100.00% <100.00%> (ø)
src/objects/tests/v2/test_notifications_send.py 100.00% <100.00%> (ø)
src/objects/tests/v2/test_object_api.py 100.00% <100.00%> (ø)
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c08221d...c7eb0ee. Read the comment docs.

src/objects/api/validators.py Show resolved Hide resolved
src/objects/api/validators.py Outdated Show resolved Hide resolved
src/objects/core/models.py Outdated Show resolved Hide resolved
@annashamray annashamray merged commit 06f4d51 into master Dec 3, 2021
@annashamray annashamray deleted the feature/hasgeometry-check branch December 3, 2021 16:20
SonnyBA added a commit that referenced this pull request Jan 8, 2025
SonnyBA added a commit that referenced this pull request Jan 8, 2025
SonnyBA added a commit that referenced this pull request Jan 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants