-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Transgreedy mesher #16
Comments
transgreedy hardcodes the transparent voxel types:
Fixing this (dynamically detecting transparent voxels, like voxel-texture., should fix most of the above problems. |
…ansgreedy mesher Ref max-mapper/voxel#16
Cool that the mesher is coming in useful to someone. The reason I didn't commit it was because it ran a lot slower than the usual mesher and I think someone else was working on a faster version. I can't remember who right now though. |
Ah, yes; forgot about that. There is some discussion in this voxel-engine open issue: max-mapper/voxel-engine#34 - I think @shama was working on it, and @mikolalysenko has a working implementation in https://github.com/mikolalysenko/ao-mesher but it is not compatible with three.js, so it would require ndarray/gl-now integration voxel/issues#4 – which is probably a good idea anyway, but might be a ways off because of the number of three.js-dependent voxel.js-related modules that would have to update. I went ahead and PR'd this transgreedy mesher as it is now, not perfect and may be replaced with ao-mesher, but it usable with voxel.js now ;) #17 |
Add a mesher with transparent material support
voxel-texture 0.5.7+ and voxel-texture-shader 0.1.1+ now support semitransparent textures (screenshots in deathcap/voxel-texture-shader#7 (comment)), but the current meshers in 'voxel' do not. Testing with the 'greedy' mesher: placing transparent voxels on top of opaque voxels lets you see through the opaque voxels (xray effect).
@vogonistic developed a mesher called 'transgreedy' a while back, available here: https://github.com/vogonistic/mineflayer-voxel/blob/d2c541d3d83a3f16d55390b98668ce7e4a4ab1dd/transgreedy.js - it does seem to work in some cases:
but needs more testing, so I haven't PR'd it yet. May need to be updated for the latest voxel-engine (last updated a year ago), or other fixes. Tentative list of problems I've noticed so far:
The text was updated successfully, but these errors were encountered: