Fix "video" embeds with missing video URLs #110
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
odrling
force-pushed
the
fix-videoembed-conversion
branch
from
89a4e5e to
efe05c1
Compare
sumnerevans
reviewed
Aug 2, 2023
odrling
force-pushed
the
fix-videoembed-conversion
branch
from
2c0ffc0 to
73bb634
Compare
Ran into an (old) message with a video embed from an unreachable website while backfilling on a large server with a few messages from 6 years ago. The bridge crashed before patch. Co-authored-by: Sumner Evans <[email protected]>
odrling
force-pushed
the
fix-videoembed-conversion
branch
from
73bb634 to
808dc7d
Compare
tulir
approved these changes
Sep 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I ran into an (old) message with a video embed from an unreachable website while backfilling on a large server with a few messages from 6 years ago.
The bridge crashed when reaching the message.