Fix "video" embeds with missing video URLs

Ran into an (old) message with a video embed from an unreachable website while backfilling on a large server with a few messages from 6 years ago. The bridge crashed before patch. Co-authored-by: Sumner Evans <[email protected]>
mautrix · Aug 2, 2023 · 73bb634 · 73bb634
1 parent 5467ab0
commit 73bb634
Showing 1 changed file with 11 additions and 1 deletion.
diff --git a/portal_convert.go b/portal_convert.go
@@ -201,8 +201,18 @@ func (portal *Portal) convertDiscordVideoEmbed(ctx context.Context, intent *apps
 	var proxyURL string
 	if embed.Video != nil {
 		proxyURL = embed.Video.ProxyURL
-	} else {
+	} else if embed.Thumbnail != nil {
 		proxyURL = embed.Thumbnail.ProxyURL
+	} else {
+		zerolog.Ctx(ctx).Error().Str("embed_url", embed.URL).Msg("failed to bridge media")
+		return &ConvertedMessage{
+			AttachmentID: attachmentID,
+			Type:         event.EventMessage,
+			Content: &event.MessageEventContent{
+				Body:    body,
+				MsgType: event.MsgNotice,
+			},
+		}
 	}
 	dbFile, err := portal.bridge.copyAttachmentToMatrix(intent, proxyURL, portal.Encrypted, NoMeta)
 	if err != nil {