Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[GH-41]:Fixed issue #41 to restrict user for channel related command #99

Merged
merged 1 commit into from
Jul 16, 2024
Merged

[GH-41]:Fixed issue #41 to restrict user for channel related command #99

merged 1 commit into from
Jul 16, 2024

Conversation

Kshitij-Katiyar
Copy link
Contributor

Summary

  • Adds Restriction to Channel-related slash commands to run only by channel admin or system admin.
  • This PR contains all the changes from Pr #78 So this PR alone is enough to fix this issue so we can close Pr #78 afterward.

Issue

@Kshitij-Katiyar
[MI-2697]:Fixed issue mattermost-community#41 to restrict user for ch…
f6fcffd 
…annel related commands (#1)

* [MI-2697]:Fixed issue mattermost-community#41 to restrict user for channel related commands

* [MI-2697]:Fixed review comment

* [MI-2697]:Fixed review comments
@mattermost-build
Copy link

Hello @Kshitij-Katiyar,

Thanks for your pull request! A Core Committer will review your pull request soon. For code contributions, you can learn more about the review process here.

hanzei
hanzei approved these changes Feb 6, 2023
View reviewed changes
Copy link
Contributor

@hanzei hanzei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hanzei hanzei requested a review from mickmister February 6, 2023 08:03
@hanzei hanzei added the 2: Dev Review Requires review by a core committer label Feb 6, 2023
@hanzei hanzei added this to the v1.3.0 milestone Feb 6, 2023
@hanzei hanzei added 3: QA Review Requires review by a QA tester and removed 2: Dev Review Requires review by a core committer labels Feb 6, 2023
@hanzei hanzei requested review from DHaussermann and removed request for mickmister February 6, 2023 10:48
@mattermost-build
Copy link

This PR has been automatically labelled "stale" because it hasn't had recent activity.
A core team member will check in on the status of the PR to help with questions.
Thank you for your contribution!

@DHaussermann DHaussermann modified the milestones: v1.3.0, v1.4.0 May 3, 2023
@hanzei hanzei requested review from AayushChaudhary0001 and removed request for DHaussermann October 16, 2023 20:37
@AayushChaudhary0001
Copy link

Tested for the following scenarios:-

  • Only channel admins and system admins are able to run the channel-related slash commands.
  • Any normal user receives a message on running any channel-related slash commands.

Working fine for the above scenarios, Approved.

@hanzei hanzei added 4: Reviews Complete All reviewers have approved the pull request and removed 3: QA Review Requires review by a QA tester labels Jan 4, 2024
@hanzei hanzei linked an issue Feb 19, 2024 that may be closed by this pull request
Restrict Channel specific Welcome Bot message config to users who have permission to manage channels #41
Closed
@raghavaggarwal2308 raghavaggarwal2308 merged commit 1fe2881 into mattermost-community:master Jul 16, 2024
@raghavaggarwal2308 raghavaggarwal2308 deleted the MM-41 branch July 16, 2024 11:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AayushChaudhary0001 AayushChaudhary0001 AayushChaudhary0001 approved these changes

@catalintomai catalintomai catalintomai approved these changes

@hanzei hanzei hanzei approved these changes

@mickmister mickmister mickmister approved these changes

Assignees

@Kshitij-Katiyar Kshitij-Katiyar

Labels
4: Reviews Complete All reviewers have approved the pull request
Projects
None yet
Milestone
v1.4.0
Development

Successfully merging this pull request may close these issues.

Restrict Channel specific Welcome Bot message config to users who have permission to manage channels
8 participants
@Kshitij-Katiyar @mattermost-build @AayushChaudhary0001 @mickmister @hanzei @catalintomai @DHaussermann @raghavaggarwal2308