Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restrict Channel specific Welcome Bot message config to users who have permission to manage channels #41

Closed
DHaussermann opened this issue Apr 9, 2020 · 1 comment · Fixed by #99
Labels
Difficulty/1:Easy Easy ticket Hacktoberfest Help Wanted Community help wanted Tech/Go Type/Enhancement New feature or improvement of existing feature
Milestone

Comments

@DHaussermann
Copy link

PR #31 introduced slash commands to manage channel specific welcome bot messages.
set_channel_welcome, get_channel_welcome and delete_channel_welcome

When an enterprise license is applied not all roles have the ability to manage channels. Therefore these commands should only be available to Channel Admin roles.

@iomodo iomodo added the Triage label Apr 14, 2020
@levb levb added Difficulty/1:Easy Easy ticket Help Wanted Community help wanted Tech/Go Type/Enhancement New feature or improvement of existing feature Up For Grabs Ready for help from the community. Removed when someone volunteers labels Apr 21, 2020
@levb levb added this to the v1.3.0 milestone Apr 21, 2020
@iomodo iomodo removed their assignment May 25, 2020
@hanzei hanzei removed the Up For Grabs Ready for help from the community. Removed when someone volunteers label Jun 3, 2021
maisnamrajusingh pushed a commit to demansoltech/mattermost-plugin-welcomebot that referenced this issue Jun 13, 2021
@maisnamrajusingh maisnamrajusingh mentioned this issue Jun 14, 2021
@maisnamrajusingh maisnamrajusingh mentioned this issue Jun 17, 2021
maisnamrajusingh pushed a commit to demansoltech/mattermost-plugin-welcomebot that referenced this issue Jun 17, 2021
@mickmister
Copy link
Contributor

There's an abandoned PR for this here #78

Kshitij-Katiyar added a commit to Brightscout/mattermost-plugin-welcomebot that referenced this issue Feb 1, 2023
Kshitij-Katiyar added a commit to Brightscout/mattermost-plugin-welcomebot that referenced this issue Feb 6, 2023
…annel related commands (#1)

* [MI-2697]:Fixed issue mattermost-community#41 to restrict user for channel related commands

* [MI-2697]:Fixed review comment

* [MI-2697]:Fixed review comments
@mkdbns mkdbns moved this from Todo to Submitted in Brightscout Plugin Maintenance Apr 28, 2023
@DHaussermann DHaussermann modified the milestones: v1.3.0, v1.4.0 May 3, 2023
raghavaggarwal2308 pushed a commit that referenced this issue Jul 16, 2024
…ds (#1) (#99)

* [MI-2697]:Fixed issue #41 to restrict user for channel related commands

* [MI-2697]:Fixed review comment

* [MI-2697]:Fixed review comments
@github-project-automation github-project-automation bot moved this from Submitted to Done in Demansol Sprint Planning Jul 16, 2024
@github-project-automation github-project-automation bot moved this from Submitted / In Review to Done in Brightscout Plugin Maintenance Jul 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment