Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add autocomplete icon #72

Closed
hanzei opened this issue Sep 9, 2020 · 4 comments · Fixed by #74
Closed

Add autocomplete icon #72

hanzei opened this issue Sep 9, 2020 · 4 comments · Fixed by #74
Assignees
@goldsziggy
Labels
Difficulty/1:Easy Easy ticket Good First Issue Suitable for first-time contributors Hacktoberfest Help Wanted Community help wanted Tech/Go
Milestone
v1.3.0

Comments

@hanzei
Copy link
Collaborator

hanzei commented Sep 9, 2020 •
edited
Loading

Since v5.24 slash commands can provide an svg via AutocompleteIconData in model.Command that is then shown in the autocomplete list. This ticket is about adding the icon in assets to the slash command.

Include screenhots from a dark and a bright theme in the PR description, as there might be the need for a separate icon with a white background for autocomplete.

Similar PRs:
For GitHub plugin mattermost/mattermost-plugin-github#359
For Jira plugin mattermost/mattermost-plugin-jira#653
@hanzei hanzei added Good First Issue Suitable for first-time contributors Help Wanted Community help wanted Difficulty/1:Easy Easy ticket Hacktoberfest Tech/Go Up For Grabs Ready for help from the community. Removed when someone volunteers labels Sep 9, 2020
@hanzei hanzei changed the title Add icon to autocomplete data Add autocomplete icon Sep 9, 2020
@hanzei hanzei added this to the v1.3.0 milestone Sep 9, 2020
@goldsziggy
Copy link
Contributor

I'd like to take this

@hanzei
Copy link
Collaborator Author

hanzei commented Oct 7, 2020

Awesome, thanks @goldsziggy Let me know if you have any questions.

@hanzei hanzei removed the Up For Grabs Ready for help from the community. Removed when someone volunteers label Oct 7, 2020
goldsziggy pushed a commit to goldsziggy/mattermost-plugin-confluence that referenced this issue Oct 9, 2020
feat(autocomplete-icon): added support for the autocomplete icon
4919e32 
this changeset changes behavior on how the command is generated to use the new experiemental command
features

fix mattermost-community#72
@goldsziggy goldsziggy mentioned this issue Oct 9, 2020
Merged
@goldsziggy
Copy link
Contributor

@hanzei I threw my attempt up for this one. I couldn't exactly follow the same edits as the two other mentioned plugins as this one is structured slightly different.

Let me know if that works!!

@hanzei
Copy link
Collaborator Author

hanzei commented Oct 9, 2020

That looks quite good 👍 Nice use of an Interface

goldsziggy pushed a commit to goldsziggy/mattermost-plugin-confluence that referenced this issue Oct 9, 2020
improvement(autocomplete): use a single svg, removed newline, and cha…
1e0cba7 
…nged autocomplete description

addressing concerns in PR comments

re mattermost-community#72
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@goldsziggy goldsziggy

Labels
Difficulty/1:Easy Easy ticket Good First Issue Suitable for first-time contributors Hacktoberfest Help Wanted Community help wanted Tech/Go
Projects
None yet
Milestone
v1.3.0
2 participants
@goldsziggy @hanzei