improvement(autocomplete): use a single svg, removed newline, and cha…

…nged autocomplete description addressing concerns in PR comments re mattermost-community#72
goldsziggy · Oct 9, 2020 · 1e0cba7 · 1e0cba7
1 parent 4919e32
commit 1e0cba7
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 23 deletions.
diff --git a/assets/icon-small.svg b/assets/icon-small.svg
diff --git a/assets/icon.svg b/assets/icon.svg
diff --git a/server/command/command.go b/server/command/command.go
@@ -4,10 +4,9 @@ import (
 	"fmt"
 	"strings"
 
-	"github.com/pkg/errors"
-
 	"github.com/mattermost/mattermost-plugin-api/experimental/command"
 	"github.com/mattermost/mattermost-server/v5/model"
+	"github.com/pkg/errors"
 
 	"github.com/mattermost/mattermost-plugin-confluence/server/config"
 	"github.com/mattermost/mattermost-plugin-confluence/server/serializer"
@@ -79,7 +78,7 @@ var ConfluenceCommandHandler = Handler{
 }
 
 func GetCommand(pAPI PluginAPI) (*model.Command, error) {
-	iconData, err := command.GetIconData(pAPI, "assets/icon-small.svg")
+	iconData, err := command.GetIconData(pAPI, "assets/icon.svg")
 	if err != nil {
 		return nil, errors.Wrap(err, "failed to get icon data")
 	}
@@ -89,15 +88,15 @@ func GetCommand(pAPI PluginAPI) (*model.Command, error) {
 		DisplayName:          "Confluence",
 		Description:          "Integration with Confluence.",
 		AutoComplete:         true,
-		AutoCompleteDesc:     "Available commands: subscribe, list, unsubscribe \"<name>\", edit \"<name>\", install cloud/server, help.",
+		AutoCompleteDesc:     "Available commands: subscribe, list, unsubscribe, edit, install, help.",
 		AutoCompleteHint:     "[command]",
 		AutocompleteData:     getAutoCompleteData(),
 		AutocompleteIconData: iconData,
 	}, nil
 }
 
 func getAutoCompleteData() *model.AutocompleteData {
-	confluence := model.NewAutocompleteData("confluence", "[command]", "Available commands: subscribe, list, unsubscribe \"<name>\", edit \"<name>\", install cloud/server, help")
+	confluence := model.NewAutocompleteData("confluence", "[command]", "Available commands: subscribe, list, unsubscribe, edit, install, help")
 
 	install := model.NewAutocompleteData("install", "", "Connect Mattermost to a Confluence instance")
 	installItems := []model.AutocompleteListItem{{