[esArchiver] stable archives (elastic#30477) (elastic#30706)

* [esArchiver/save] serialize with stable json stringify

* [esArchives] rebuild all archives

package.json

@@ -363,6 +363,7 @@
     "jest-cli": "^23.6.0",
     "jest-raw-loader": "^1.0.1",
     "jimp": "0.2.28",
+    "json-stable-stringify": "^1.0.1",
     "json5": "^1.0.1",
     "karma": "3.1.4",
     "karma-chrome-launcher": "2.1.1",

packages/kbn-dev-utils/src/streams/concat_stream.js

@@ -33,7 +33,6 @@ import { createReduceStream } from './reduce_stream';
  *  Concatenate values into an array:
  *    createListStream([1,2,3])
  *      .pipe(createConcatStream([]))
- *      .pipe(createJsonStringifyStream())
  *      .on('data', console.log)
  *      // logs "[1,2,3]"
  *

src/es_archiver/lib/archives/format.js

@@ -20,16 +20,18 @@
 import { createGzip, Z_BEST_COMPRESSION } from 'zlib';
 import { PassThrough } from 'stream';
 
+import stringify from 'json-stable-stringify';
+
 import {
+  createMapStream,
   createIntersperseStream,
-  createJsonStringifyStream
 } from '../../../legacy/utils';
 
 import { RECORD_SEPARATOR } from './constants';
 
 export function createFormatArchiveStreams({ gzip = false } = {}) {
   return [
-    createJsonStringifyStream({ pretty: true }),
+    createMapStream(record => stringify(record, { space: '  ' })),
     createIntersperseStream(RECORD_SEPARATOR),
     gzip ? createGzip({ level: Z_BEST_COMPRESSION }) : new PassThrough(),
   ];

src/es_archiver/lib/archives/parse.js

@@ -23,7 +23,7 @@ import { PassThrough } from 'stream';
 import {
   createSplitStream,
   createReplaceStream,
-  createJsonParseStream,
+  createMapStream,
 } from '../../../legacy/utils';
 
 import { RECORD_SEPARATOR } from './constants';
@@ -33,6 +33,6 @@ export function createParseArchiveStreams({ gzip = false } = {}) {
     gzip ? createGunzip() : new PassThrough(),
     createReplaceStream('\r\n', '\n'),
     createSplitStream(RECORD_SEPARATOR),
-    createJsonParseStream(),
+    createMapStream(json => JSON.parse(json.trim())),
   ];
 }

src/legacy/utils/index.js

@@ -39,8 +39,6 @@ export {
   concatStreamProviders,
   createConcatStream,
   createIntersperseStream,
-  createJsonParseStream,
-  createJsonStringifyStream,
   createListStream,
   createPromiseFromStreams,
   createReduceStream,

src/legacy/utils/streams/concat_stream.js

@@ -33,7 +33,6 @@ import { createReduceStream } from './reduce_stream';
  *  Concatenate values into an array:
  *    createListStream([1,2,3])
  *      .pipe(createConcatStream([]))
- *      .pipe(createJsonStringifyStream())
  *      .on('data', console.log)
  *      // logs "[1,2,3]"
  *

src/legacy/utils/streams/index.js

@@ -22,7 +22,6 @@ export { createIntersperseStream } from './intersperse_stream';
 export { createSplitStream } from './split_stream';
 export { createListStream } from './list_stream';
 export { createReduceStream } from './reduce_stream';
-export { createJsonParseStream, createJsonStringifyStream } from './json_streams';
 export { createPromiseFromStreams } from './promise_from_streams';
 export { createConcatStream } from './concat_stream';
 export { createMapStream } from './map_stream';