[esArchiver] stable archives #30477
Merged
[esArchiver] stable archives #30477
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
spalger
force-pushed
the
fix/esArchiver-stable-archives
branch
from
db809ad to
a114e6e
Compare
💚 Build Succeeded |
spalger
force-pushed
the
fix/esArchiver-stable-archives
branch
from
a114e6e to
38b9db4
Compare
💚 Build Succeeded |
spalger
pushed a commit
to spalger/kibana
that referenced
this pull request
Feb 11, 2019
* [esArchiver/save] serialize with stable json stringify * [esArchives] rebuild all archives
spalger
pushed a commit
to spalger/kibana
that referenced
this pull request
Feb 11, 2019
* [esArchiver/save] serialize with stable json stringify * [esArchives] rebuild all archives
spalger
pushed a commit
that referenced
this pull request
Feb 12, 2019
spalger
pushed a commit
that referenced
this pull request
Feb 14, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When serializing documents to store in the archive, use a stable JSON stringify so that loading and saving the archive produces unchanged archives.
Note that 3ba5346 is just rebuilding all the archives to they use the stable sort internally.