Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add regression test for #4169 #523

Merged
merged 4 commits into from
Nov 14, 2018
Merged

Add regression test for #4169 #523

Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
2f769d4
Add regression test for #4169
dbkr Nov 9, 2018
82ab169
retest
dbkr Nov 9, 2018
78aefae
Abort as soon as a create attempt fails
dbkr Nov 9, 2018
3f51975
'bug' seems to imply 'expected fail'
dbkr Nov 13, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 15 additions & 0 deletions tests/41end-to-end-keys/07-backup.pl
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
use Future::Utils qw( repeat );

my $fixture = local_user_fixture();

test "Can create backup version",
Expand Down Expand Up @@ -347,6 +349,19 @@
});
};

test "Can create more than 10 backup versions",
requires => [ $fixture ],

bug => 'synapse/4169',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this does what you want. It marks the test as an "expected failure".

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume it only does this while the bug is still open though?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You'd be wrong :) The string isn't interpreted at all, and certainly doesn't go and check the status of any linked issue (nor is there any consistency in the format of the string)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks like you're right though


do => sub {
my ( $user ) = @_;

repeat( sub {
matrix_create_key_backup( $user );
}, foreach => [ 0 .. 10 ], while => sub { $_[0] -> is_done });
};


=head2 matrix_create_key_backup

Expand Down