Add regression test for #4169 #523
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think you can do something like: try_repeat( sub {
matrix_create_key_backup( $user );
}, foreach => [ 0 .. 10 ], while => sub { $_[0] -> is_done } );whether it's worth doing so, I couldn't say... |
|
the code lgtm but I'm not reassured by the failures! |
|
That's better. Ptal! |
richvdh
requested changes
Nov 12, 2018
tests/41end-to-end-keys/07-backup.pl
Outdated
| test "Can create more than 10 backup versions", | ||
| requires => [ $fixture ], | ||
|
|
||
| bug => 'synapse/4169', |
There was a problem hiding this comment.
I don't think this does what you want. It marks the test as an "expected failure".
There was a problem hiding this comment.
I assume it only does this while the bug is still open though?
There was a problem hiding this comment.
You'd be wrong :) The string isn't interpreted at all, and certainly doesn't go and check the status of any linked issue (nor is there any consistency in the format of the string)
There was a problem hiding this comment.
looks like you're right though
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test for matrix-org/synapse#4113
If this fails, it keeps going through the 10 versions which isn't ideal. I tried using the repeat+foreach+while to terminate it but couldn't get it to abort. Feedback welcome on the right runes to make this happen.