This repository has been archived by the owner on Apr 26, 2024. It is now read-only.
-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
Add an openidish mechanism for proving that you own a given user_id #765
Merged
Merged
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,96 @@ | ||
# -*- coding: utf-8 -*- | ||
# Copyright 2015, 2016 OpenMarket Ltd | ||
# | ||
# Licensed under the Apache License, Version 2.0 (the "License"); | ||
# you may not use this file except in compliance with the License. | ||
# You may obtain a copy of the License at | ||
# | ||
# http://www.apache.org/licenses/LICENSE-2.0 | ||
# | ||
# Unless required by applicable law or agreed to in writing, software | ||
# distributed under the License is distributed on an "AS IS" BASIS, | ||
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
# See the License for the specific language governing permissions and | ||
# limitations under the License. | ||
|
||
|
||
from ._base import client_v2_patterns | ||
|
||
from synapse.http.servlet import RestServlet, parse_json_object_from_request | ||
from synapse.api.errors import AuthError | ||
from synapse.util.stringutils import random_string | ||
|
||
from twisted.internet import defer | ||
|
||
import logging | ||
|
||
logger = logging.getLogger(__name__) | ||
|
||
|
||
class IdTokenServlet(RestServlet): | ||
""" | ||
Get a bearer token that may be passed to a third party to confirm ownership | ||
of a matrix user id. | ||
|
||
The format of the response could be made compatible with the format given | ||
in http://openid.net/specs/openid-connect-core-1_0.html#TokenResponse | ||
|
||
But instead of returning a signed "id_token" the response contains the | ||
name of the issuing matrix homeserver. This means that for now the third | ||
party will need to check the validity of the "id_token" against the | ||
federation /openid/userinfo endpoint of the homeserver. | ||
|
||
Request: | ||
|
||
POST /user/{user_id}/openid/request_token?access_token=... HTTP/1.1 | ||
|
||
{} | ||
|
||
Response: | ||
|
||
HTTP/1.1 200 OK | ||
{ | ||
"access_token": "ABDEFGH", | ||
"token_type": "Bearer", | ||
"matrix_server_name": "example.com", | ||
"expires_in": 3600, | ||
} | ||
""" | ||
PATTERNS = client_v2_patterns( | ||
"/user/(?P<user_id>[^/]*)/openid/request_token" | ||
) | ||
|
||
EXPIRES_MS = 3600 * 1000 | ||
|
||
def __init__(self, hs): | ||
super(IdTokenServlet, self).__init__() | ||
self.auth = hs.get_auth() | ||
self.store = hs.get_datastore() | ||
self.clock = hs.get_clock() | ||
self.server_name = hs.config.server_name | ||
|
||
@defer.inlineCallbacks | ||
def on_POST(self, request, user_id): | ||
requester = yield self.auth.get_user_by_req(request) | ||
if user_id != requester.user.to_string(): | ||
raise AuthError(403, "Cannot request tokens for other users.") | ||
|
||
# Parse the request body to make sure it's JSON, but ignore the contents | ||
# for now. | ||
parse_json_object_from_request(request) | ||
|
||
token = random_string(24) | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Should this be a macaroon to keep it consistent with the other tokens? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Maybe, something we can change down the line if needed. |
||
ts_valid_until_ms = self.clock.time_msec() + self.EXPIRES_MS | ||
|
||
yield self.store.insert_open_id_token(token, ts_valid_until_ms, user_id) | ||
|
||
defer.returnValue((200, { | ||
"access_token": token, | ||
"token_type": "Bearer", | ||
"matrix_server_name": self.server_name, | ||
"expires_in": self.EXPIRES_MS / 1000, | ||
})) | ||
|
||
|
||
def register_servlets(hs, http_server): | ||
IdTokenServlet(hs).register(http_server) |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,32 @@ | ||
from ._base import SQLBaseStore | ||
|
||
|
||
class OpenIdStore(SQLBaseStore): | ||
def insert_open_id_token(self, token, ts_valid_until_ms, user_id): | ||
return self._simple_insert( | ||
table="open_id_tokens", | ||
values={ | ||
"token": token, | ||
"ts_valid_until_ms": ts_valid_until_ms, | ||
"user_id": user_id, | ||
}, | ||
desc="insert_open_id_token" | ||
) | ||
|
||
def get_user_id_for_open_id_token(self, token, ts_now_ms): | ||
def get_user_id_for_token_txn(txn): | ||
sql = ( | ||
"SELECT user_id FROM open_id_tokens" | ||
" WHERE token = ? AND ? <= ts_valid_until_ms" | ||
) | ||
|
||
txn.execute(sql, (token, ts_now_ms)) | ||
|
||
rows = txn.fetchall() | ||
if not rows: | ||
return None | ||
else: | ||
return rows[0][0] | ||
return self.runInteraction( | ||
"get_user_id_for_token", get_user_id_for_token_txn | ||
) |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,9 @@ | ||
|
||
CREATE TABLE open_id_tokens ( | ||
token TEXT NOT NULL PRIMARY KEY, | ||
ts_valid_until_ms bigint NOT NULL, | ||
user_id TEXT NOT NULL, | ||
UNIQUE (token) | ||
); | ||
|
||
CREATE index open_id_tokens_ts_valid_until_ms ON open_id_tokens(ts_valid_until_ms); |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is
access_token
something part of the OpenID spec? Or defined by us? I'd rather not have two different meanings foraccess_token
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's part of the OpenID/Oauth spec I'm afraid.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sad face