This repository has been archived by the owner on Apr 26, 2024. It is now read-only.
Add an openidish mechanism for proving that you own a given user_id #765
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| Request: | ||
|
|
||
| POST /user/{user_id}/openid/token?access_token=... HTTP/1.1 |
There was a problem hiding this comment.
This doesn't feel obvious that this is provisioning a new token, rather than something else.
Maybe GET or /openid/provision_token?
There was a problem hiding this comment.
I was thieving the method and path from http://openid.net/specs/openid-connect-core-1_0.html#TokenRequest.
There was a problem hiding this comment.
Eww. Would still prefer at least /user/{user_id}/openid/request/token or something, anything really
|
LGTM |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Doesn't actually fully implement open id yet. but the intention is that response format could be made compatible with that expected from open id.
However it does have enough machinery to prove ownership of a given user_id which is probably a good start.