This repository has been archived by the owner on Apr 26, 2024. It is now read-only.
Make 'event_id' a required parameter in federated state requests #4741
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As per the spec: https://matrix.org/docs/spec/server_server/r0.1.1.html#id40 Signed-off-by: Joseph Weston <[email protected]>
Signed-off-by: Joseph Weston <[email protected]>
hawkowl
changed the title
Codecov Report
@@ Coverage Diff @@
## develop #4741 +/- ##
==========================================
+ Coverage 75.1% 75.1% +<.01%
==========================================
Files 340 340
Lines 34853 34853
Branches 5709 5709
==========================================
+ Hits 26175 26178 +3
+ Misses 7067 7065 -2
+ Partials 1611 1610 -1 |
3 tasks
erikjohnston
approved these changes
Feb 26, 2019
|
Thanks again to @jbweston for contributing this patch. |
I just saw that the spec says that it's a required parameter: I'm not sure if it makes sense for the spec to define it as a required parameter |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Paired with matrix-org/sytest#566, replaces #4740
Closes #3646
From the original PR: