Make 'event_id' a required parameter in federated state requests (#4741)

* make 'event_id' a required parameter in federated state requests As per the spec: https://matrix.org/docs/spec/server_server/r0.1.1.html#id40 Signed-off-by: Joseph Weston <[email protected]> * add changelog entry for bugfix Signed-off-by: Joseph Weston <[email protected]> * Update server.py
matrix-org · Feb 27, 2019 · b131cc7 · b131cc7
1 parent 68f47d6
commit b131cc7
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 2 deletions.
diff --git a/changelog.d/4740.bugfix b/changelog.d/4740.bugfix
@@ -0,0 +1 @@
+'event_id' is now a required parameter in federated state requests, as per the matrix spec.
diff --git a/synapse/federation/transport/server.py b/synapse/federation/transport/server.py
@@ -393,7 +393,7 @@ def on_GET(self, origin, content, query, context):
         return self.handler.on_context_state_request(
             origin,
             context,
-            parse_string_from_args(query, "event_id", None),
+            parse_string_from_args(query, "event_id", None, required=True),
         )
 
 
@@ -404,7 +404,7 @@ def on_GET(self, origin, content, query, room_id):
         return self.handler.on_state_ids_request(
             origin,
             room_id,
-            parse_string_from_args(query, "event_id", None),
+            parse_string_from_args(query, "event_id", None, required=True),
         )
Original file line number	Diff line number	Diff line change
		@@ -0,0 +1 @@
		'event_id' is now a required parameter in federated state requests, as per the matrix spec.