/unban broken

[Zenexer]

Moved from matrix-org/matrix-js-sdk#341

/unban is broken on clients that use /rooms/{roomId}/state/leave to unban users instead of /rooms/{roomId}/unban. The user will receive the following error:

Cannot leave user who was banned

synapse/synapse/handlers/room_member.py

Line 228 in f0e4bac

"Cannot %s user who was banned" % (action,),

The cause is this line: when using the old/alternative method of unbanning users, action will be "leave" instead of "unban".

However, fixing this without also updating the client(s) will result in the return of element-hq/element-web#1961, which is likely fixed at the moment. This is because the server will be unable to differentiate between /kick and /unban. matrix-js-sdk will need to be updated to use what I assume is the "new" API call.

[richvdh]

I don't think this bug is valid any more. If it is, please open a new bug stating clearly how synapse doesn't match the spec.