/unban and /kick don't work

[Zenexer]

/unban appears to be the same thing as /leave

Likely cause:

matrix-js-sdk/src/client.js

Line 1300 in 9c6973a

this, roomId, userId, "leave", undefined, callback

[Zenexer]

Looks like /kick has the same bug.

[Zenexer]

My understanding, after a (very) brief read, is that each user has a state relative to a room. "leave" is the state that results from /unban, /kick, and /part, which I assume means there's another state akin to "banned". There's a leave API call to set this state on a user; if not passed a user ID, it defaults to self. Formerly, this handled all three commands that set the "leave" state, but more recently, they were split into separate API calls. The functions mapped to the slash commands were never updated accordingly.

This would also explain why element-hq/element-web#1961 occurred: at one point in time, /unban and /kick were essentially the same command: leave plus an optional user ID. It's probably worth checking to ensure users can't call leave without a user ID to unban themselves.

[Zenexer]

Moved to matrix-org/synapse#1860

[fred-wang]

@Zenexer So shouldn't we also update

matrix-js-sdk/src/client.js

Line 1300 in 9c6973a

this, roomId, userId, "leave", undefined, callback

to to send "unban" instead of "leave"?

[Zenexer]

@fred-wang I believe so. Also, I think

matrix-js-sdk/src/client.js

Line 1314 in 9c6973a

this, roomId, userId, "leave", reason, callback

should be kick. Both changes worked when I tested them, and are correct according to the current spec.

[Zenexer]

Actually, here are the exact changes that need to be made: https://github.com/matrix-org/matrix-js-sdk/pull/342/files You can reopen that if you want. I forget where I was told it wouldn't be accepted; I think it was in one of the development rooms.

[fred-wang]

I don't think I have the permission to reopen this, maybe we should ask to one matrix dev.

My guess is that it breaks compatibility with server using the old API but at some point it should really be taken.