-
Notifications
You must be signed in to change notification settings - Fork 386
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix room tags spec #1457
Fix room tags spec #1457
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,4 +1,5 @@ | ||
.. Copyright 2016 OpenMarket Ltd | ||
.. Copyright 2018 New Vector Ltd | ||
.. | ||
.. Licensed under the Apache License, Version 2.0 (the "License"); | ||
.. you may not use this file except in compliance with the License. | ||
|
@@ -17,22 +18,19 @@ Room Tagging | |
|
||
.. _module:tagging: | ||
|
||
Users can add tags to rooms. Tags are short strings used to label rooms, e.g. | ||
"work", "family". A room may have multiple tags. Tags are only visible to the | ||
user that set them but are shared across all their devices. | ||
Users can add tags to rooms. Tags are namespaced strings used to label rooms. | ||
A room may have multiple tags. Tags are only visible to the user that set them | ||
but are shared across all their devices. | ||
|
||
Events | ||
------ | ||
|
||
The tags on a room are received as single ``m.tag`` event in the | ||
``account_data`` section of a room in a ``/sync``. | ||
``account_data`` section of a room. The content of the ``m.tag`` event is a | ||
``tags`` key whose value is an object mapping the name of each tag to another | ||
object. | ||
|
||
The ``m.tag`` can also be received in a ``/events`` response or in the | ||
``account_data`` section of a room in ``/initialSync``. ``m.tag`` | ||
events appearing in ``/events`` will have a ``room_id`` with the room | ||
the tags are for. | ||
|
||
Each tag has an associated JSON object with information about the tag, e.g how | ||
The JSON object associated with each tag gives information about the tag, e.g how | ||
to order the rooms with a given tag. | ||
|
||
Ordering information is given under the ``order`` key as a number between 0 and | ||
|
@@ -43,26 +41,28 @@ after the rooms with that tag that have an ``order`` key. | |
|
||
The name of a tag MUST not exceed 255 bytes. | ||
|
||
The name of a tag should be human readable. When displaying tags for a room a | ||
client should display this human readable name. When adding a tag for a room | ||
a client may offer a list to choose from that includes all the tags that the | ||
user has previously set on any of their rooms. | ||
Tags namespaces are defined in the following way, depending on how the client are expected to interpret them: | ||
|
||
* The namespace ``m.*`` is reserved for tags defined in the Matrix specification. Clients must ignore | ||
any tags in this namespace they don't understand. | ||
* The namespace ``u.*`` is reserved for user-defined tags. The portion of the string after the ``u.`` | ||
is defined to be the display name of this tag. No other semantics should be inferred from tags in | ||
this namespace. | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Note change here defining the behaviour of stripping the There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This was indeed the original intent of #1054 |
||
* A client or app willing to use special tags for advanced functionnality should namespace them similarly to state keys: ``tld.name.*`` | ||
* Any tag in the ``tld.name.*`` form but not matching the namespace of the current client should be ignored | ||
* Any tag not matching the above rules should be interpreted as a user tag from the ``u.*`` namespace, as if | ||
the name had already had ``u.`` stripped from the start (ie. the name of the tag is used as the | ||
display name directly). These non-namespaced tags are supported for historical reasons. New tags should use | ||
one of the defined namespaces above. | ||
|
||
Two special names are listed in the specification: | ||
The following tags are defined in the ``m.*`` namespace: | ||
|
||
* ``m.favourite`` | ||
* ``m.lowpriority`` | ||
* ``m.favourite``: The user's favourite rooms. These should be shown with higher precedence than other rooms. | ||
* ``m.lowpriority``: These should be shown with lower precedence than others. | ||
|
||
{{m_tag_event}} | ||
|
||
Tags namespaces are defined in the following way, depending on how the client are expected to interpret them: | ||
|
||
* The namespace ``m.*`` is reserved for tags defined in the current specification | ||
* The namespace ``u.*`` is reserved for user-defined tags, and the client should not try to interpret as anything other than an utf8 string | ||
* A client or app willing to use special tags for advanced functionnality should namespace them similarly to state keys: ``tld.name.*`` | ||
* Any tag in the ``tld.name.*`` form but not matching the namespace of the current client should be ignored | ||
* Any tag not matching the previous rules should be interpreted as an user tag from the ``u.*`` namespace | ||
|
||
Client Behaviour | ||
---------------- | ||
|
||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor change here: s.current/Matrix/ (the
m.
namespace is reserved for any version of the spec, not just this one)