Fix room tags spec #1457
Merged
Fix room tags spec #1457
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dbkr
commented
Jul 27, 2018
| any tags in this namespace they don't understand. | ||
| * The namespace ``u.*`` is reserved for user-defined tags. The portion of the string after the ``u.`` | ||
| is defined to be the display name of this tag. No other semantics should be inferred from tags in | ||
| this namespace. |
There was a problem hiding this comment.
Note change here defining the behaviour of stripping the u. to get the display name which I assume was what this intended.
There was a problem hiding this comment.
This was indeed the original intent of #1054
dbkr
commented
Jul 27, 2018
| Tags namespaces are defined in the following way, depending on how the client are expected to interpret them: | ||
|
|
||
| * The namespace ``m.*`` is reserved for tags defined in the Matrix specification. Clients must ignore | ||
| any tags in this namespace they don't understand. |
There was a problem hiding this comment.
Minor change here: s.current/Matrix/ (the m. namespace is reserved for any version of the spec, not just this one)
turt2live
approved these changes
Jul 27, 2018
KitsuneRal
approved these changes
Jul 28, 2018
KitsuneRal
added a commit
to quotient-im/libQuotient
that referenced
this pull request
Jul 28, 2018
See matrix-org/matrix-spec-proposals#1457 for the background.
|
This has been approved for a while - merging. |
dbkr
added a commit
to matrix-org/matrix-react-sdk
that referenced
this pull request
Aug 6, 2018
Fix Riot's behaviour with room tags after my cleanup in matrix-org/matrix-spec-proposals#1457 . Although, reading it again, it's not clear how you're supposed to tell the difference between a reverse-dns tag name and a legacy freeform text tag (contains a '.'?) - I've left it detecting these as freeform text for now.
RiotTranslateBot
pushed a commit
to RiotTranslateBot/matrix-doc
that referenced
this pull request
Aug 22, 2023
This strives to fix all remaining cases where additional attributes (most often 'description' but not only) are provided next to $ref by wrapping $ref in allOf; and also drops allOf in a couple of places where $ref is the only element under it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The room tag spec started out as plain strings, then #1054 introduced namespaces but just added a paragraph without updating any of the existing copy to reflect namespaces, making the spec contradict itself.
m.tagevent looks likem.favouriteandm.lowprioritymean...N.B. I'm trying to lead by example here by doing this a direct PR without a proposal doc, since I think this is all clarifying the existing intention of the spec rather than changing it.