Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

crypto-ffi: Expose has_verification_violation for UserIdentity #4105

Merged
merged 1 commit into from
Oct 31, 2024

Conversation

BillCarsonFr
Copy link
Member

Quick change to expose has_verification_violation in the crypto ffi layer for legacy mobile apps.

  • Public API changes documented in changelogs (optional)

Signed-off-by:

@BillCarsonFr BillCarsonFr marked this pull request as ready for review October 10, 2024 11:05
@BillCarsonFr BillCarsonFr requested a review from a team as a code owner October 10, 2024 11:05
@BillCarsonFr BillCarsonFr requested review from poljar and removed request for a team October 10, 2024 11:05
Copy link
Contributor

@poljar poljar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You need to rebase on top of main to get CI fixed.

@BillCarsonFr BillCarsonFr force-pushed the valere/crypto_ffi_expose_verification_violation branch from 7a949d7 to 49f7fe9 Compare October 31, 2024 10:05
Copy link

codecov bot commented Oct 31, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.91%. Comparing base (75683d2) to head (49f7fe9).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4105      +/-   ##
==========================================
+ Coverage   84.88%   84.91%   +0.03%     
==========================================
  Files         272      272              
  Lines       29131    29131              
==========================================
+ Hits        24729    24738       +9     
+ Misses       4402     4393       -9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@BillCarsonFr BillCarsonFr merged commit d4b9145 into main Oct 31, 2024
40 checks passed
@BillCarsonFr BillCarsonFr deleted the valere/crypto_ffi_expose_verification_violation branch October 31, 2024 10:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants