feat(crypto): Add support for verification violation warnings #8933
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bmarty
approved these changes
Nov 4, 2024
| @@ -58,7 +58,7 @@ internal class RustCrossSigningService @Inject constructor( | |||
| * Checks that my trusted user key has signed the other user UserKey | |||
| */ | |||
| override suspend fun checkUserTrust(otherUserId: String): UserTrustResult { | |||
| val identity = olmMachine.getIdentity(olmMachine.userId()) | |||
| val identity = olmMachine.getIdentity(otherUserId) | |||
There was a problem hiding this comment.
Good catch. Hopefully this code is only used in test with otherUserId different than the current user. Else I guess we would have detected the problem faster.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Fixes https://github.com/element-hq/crypto-internal/issues/384
Content
Requires a bump of crypto sdk in order to have the needed bindings matrix-org/matrix-rust-sdk#4105
Now that matrix-org/matrix-rust-sdk#1129 is fixed we can add back support for identity requirement violation notification. There was an existing test that was disabled, it is re-enabled now.
Motivation and context
Screenshots / GIFs
Tests
Tested devices
Checklist