sdk-ui: add fn Room::event_with_config
#3809
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3809 +/- ##
=======================================
Coverage 84.08% 84.08%
=======================================
Files 263 263
Lines 27475 27471 -4
=======================================
- Hits 23102 23100 -2
+ Misses 4373 4371 -2 ☔ View full report in Codecov by Sentry. |
This method works the same as `Room::event` but you can provide a custom `RequestConfig` to it. It's especially useful for the pinned events timeline, since we need a max number of retries and a max number of concurrent requests. With this we can remove some unnecessary complexity.
jmartinesp
force-pushed
the
fix/jme/use-request-config-for-loading-pinned-events
branch
from
fee6b06 to
4dc071e
Compare
jmartinesp
requested review from
a team and
stefanceriu
and removed request for
poljar and
a team
jmartinesp
deleted the
fix/jme/use-request-config-for-loading-pinned-events
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This method works the same as
Room::eventbut you can provide a customRequestConfigto it.It's especially useful for the pinned events timeline, since we need a max number of retries and a max number of concurrent requests. With this we can remove some unnecessary complexity.
Related but not depending on #3807.
Signed-off-by: