ffi: allow the clients to provide a custom RequestConfig
#3807
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3807 +/- ##
=======================================
Coverage 84.08% 84.08%
=======================================
Files 263 263
Lines 27475 27475
=======================================
+ Hits 23102 23103 +1
+ Misses 4373 4372 -1 ☔ View full report in Codecov by Sentry. |
1 task
jmartinesp
requested review from
a team,
poljar and
stefanceriu
and removed request for
poljar and
a team
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without this, the default request config would always be used. This meant having unlimited retries for almost every request, even with no network connection.
Signed-off-by: