This repository has been archived by the owner on Sep 27, 2024. It is now read-only.
Remove trailingTrimmed from withNBSP #884
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Kudos, SonarCloud Quality Gate passed!
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #884 +/- ##
============================================
+ Coverage 87.44% 89.39% +1.95%
============================================
Files 165 86 -79
Lines 18964 15324 -3640
Branches 1048 0 -1048
============================================
- Hits 16583 13699 -2884
+ Misses 2086 1625 -461
+ Partials 295 0 -295
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes an issue with double space ->
.conversion breaking formatting:RPReplay_Final1700486454.MP4
The trimming in withNBSP was added back when we were using zero-width spaces(ZWSP) as a part of the initial paragraphs work.
We no longer use ZWSP.
In #831 @aringenbach changed it to just remove trailing(not leading) space to fix that issue. Maybe it's not needed at all anymore.
Nit: Either way it probably shouldn't be a function called
withNBSPas it's not clear form the call site that it is also trimming.So unless somebody knows of a problem it is currently solving, lets remove it to fix this issue. If it causes a regression we can then solve for both cases.
@Velin92 Do you happen to remember why the trimming was needed here? And if maybe it's not needed anymore now that we use just paragraphs and no ZWSP?