Skip to content
This repository has been archived by the owner on Sep 27, 2024. It is now read-only.

Version 2.19.0 #892

Merged
merged 2 commits into from
Nov 28, 2023
Merged

Version 2.19.0 #892

merged 2 commits into from
Nov 28, 2023

Conversation

alfogrillo
Copy link
Contributor

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Nov 28, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (98f775c) 87.43% compared to head (e665260) 87.94%.

Additional details and impacted files
@@             Coverage Diff              @@
##               main     #892      +/-   ##
============================================
+ Coverage     87.43%   87.94%   +0.50%     
============================================
  Files           165      118      -47     
  Lines         18952    16912    -2040     
  Branches       1043      637     -406     
============================================
- Hits          16571    14873    -1698     
+ Misses         2086     2010      -76     
+ Partials        295       29     -266     
Flag Coverage Δ
uitests ?
uitests-android ?
uitests-ios ?
unittests 87.94% <ø> (+2.39%) ⬆️
unittests-android ?
unittests-ios 73.92% <ø> (-0.26%) ⬇️
unittests-rust 89.39% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@alfogrillo alfogrillo requested a review from a team November 28, 2023 08:27
Copy link
Contributor

@jonnyandrew jonnyandrew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just spotted a missing changelog item

CHANGELOG.md Show resolved Hide resolved
Co-authored-by: jonnyandrew <[email protected]>
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@alfogrillo
Copy link
Contributor Author

@nimau fell free to merge it when you are ready!

@nimau nimau merged commit b9e98a6 into main Nov 28, 2023
9 checks passed
@nimau nimau deleted the version-2.19.0 branch November 28, 2023 11:50
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants