Skip to content
This repository has been archived by the owner on Sep 27, 2024. It is now read-only.

[iOS] Fix pending format inconsistencies #823

Merged
merged 1 commit into from
Sep 26, 2023

Conversation

aringenbach
Copy link
Contributor

Fixes element-hq/element-x-ios#1672

Also fixes a related issue where de-selecting and selecting a list item back would not apply the formats either.
Added ViewModel unit tests for both cases.

@aringenbach aringenbach requested a review from a team September 26, 2023 14:49
@sonarcloud
Copy link

sonarcloud bot commented Sep 26, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@codecov-commenter
Copy link

codecov-commenter commented Sep 26, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (861ea18) 89.85% compared to head (e1c4d66) 88.63%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #823      +/-   ##
==========================================
- Coverage   89.85%   88.63%   -1.23%     
==========================================
  Files         113      114       +1     
  Lines       16240    16253      +13     
  Branches      604      613       +9     
==========================================
- Hits        14593    14406     -187     
- Misses       1623     1818     +195     
- Partials       24       29       +5     
Flag Coverage Δ
uitests ?
uitests-ios ?
unittests 88.63% <93.75%> (+0.09%) ⬆️
unittests-ios 76.57% <93.75%> (+1.12%) ⬆️
unittests-rust 89.88% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...WysiwygComposerView/WysiwygComposerViewModel.swift 82.37% <100.00%> (-9.06%) ⬇️
...es/WysiwygComposer/Extensions/ComposerAction.swift 87.50% <87.50%> (ø)

... and 7 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@alfogrillo alfogrillo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aringenbach aringenbach merged commit e32ea98 into main Sep 26, 2023
7 checks passed
@aringenbach aringenbach deleted the aringenbach/fix-pending-formats-inconsistencies branch September 26, 2023 15:41
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

RTE ignores span formatting if you start a bullet list, and formatting buttons get out of sync
3 participants