[Android] Fix missing link action updates in compose library #804

jonnyandrew · 2023-09-12T12:46:02Z

Problem

When moving the cursor/selection to a new position, the compose state does not update the available link action.

Solution

Previously the Android compose library only updated the available link action when the editor text changed. However, this misses any updates that result from changing the selection. To solve this:

Rust lib: return link action changes along with composer updates
Android view lib: Add a listener API to the to allow registering for link action updates
Android compose lib: Use the listener API to listen for state changes and update the compose state

codecov-commenter · 2023-09-12T15:08:48Z

Codecov Report

Patch coverage: 67.18% and project coverage change: -0.03% ⚠️

Comparison is base (c65b914) 88.31% compared to head (b498285) 88.28%.
Report is 3 commits behind head on main.

Additional details and impacted files

@@             Coverage Diff              @@
##               main     #804      +/-   ##
============================================
- Coverage     88.31%   88.28%   -0.03%     
- Complexity      364      367       +3     
============================================
  Files           154      155       +1     
  Lines         17837    17881      +44     
  Branches        864      862       -2     
============================================
+ Hits          15753    15787      +34     
- Misses         1847     1860      +13     
+ Partials        237      234       -3

Flag	Coverage Δ
uitests	`74.47% <77.50%> (+0.26%)`	⬆️
uitests-android	`69.25% <77.50%> (+0.58%)`	⬆️
uitests-ios	`80.14% <ø> (ø)`
unittests	`86.92% <48.97%> (-0.07%)`	⬇️
unittests-android	`50.48% <48.00%> (+0.13%)`	⬆️
unittests-ios	`75.52% <ø> (ø)`
unittests-rust	`89.88% <50.00%> (-0.07%)`	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed	Coverage Δ
bindings/wysiwyg-ffi/src/ffi_composer_update.rs	`95.76% <0.00%> (-1.24%)`	⬇️
bindings/wysiwyg-ffi/src/ffi_link_actions.rs	`0.00% <0.00%> (ø)`
.../java/io/element/android/wysiwyg/EditorEditText.kt	`64.62% <66.66%> (-0.40%)`	⬇️
...roid/wysiwyg/internal/view/models/LinkActionExt.kt	`66.66% <66.66%> (ø)`
...roid/wysiwyg/internal/viewmodel/EditorViewModel.kt	`53.73% <80.00%> (+7.63%)`	⬆️
crates/wysiwyg/src/composer_model/base.rs	`94.87% <100.00%> (+0.08%)`	⬆️
crates/wysiwyg/src/composer_model/replace_text.rs	`79.14% <100.00%> (+0.11%)`	⬆️
crates/wysiwyg/src/composer_update.rs	`100.00% <100.00%> (ø)`
crates/wysiwyg/src/link_action.rs	`100.00% <100.00%> (ø)`
.../element/android/wysiwyg/compose/RichTextEditor.kt	`64.04% <100.00%> (+1.25%)`	⬆️