[Android] Fix missing link action updates in compose library (#804)

bindings/wysiwyg-ffi/src/ffi_composer_update.rs

@@ -1,5 +1,6 @@
 use widestring::Utf16String;
 
+use crate::ffi_link_actions::LinkActionUpdate;
 use crate::ffi_menu_state::MenuState;
 use crate::ffi_text_update::TextUpdate;
 use crate::MenuAction;
@@ -28,6 +29,10 @@ impl ComposerUpdate {
     pub fn menu_action(&self) -> MenuAction {
         MenuAction::from(self.inner.menu_action.clone())
     }
+
+    pub fn link_action(&self) -> LinkActionUpdate {
+        LinkActionUpdate::from(self.inner.link_action.clone())
+    }
 }
 
 #[cfg(test)]

bindings/wysiwyg-ffi/src/ffi_link_actions.rs

@@ -20,3 +20,20 @@ impl From<wysiwyg::LinkAction<Utf16String>> for LinkAction {
         }
     }
 }
+
+#[derive(uniffi::Enum)]
+pub enum LinkActionUpdate {
+    Keep,
+    Update { link_action: LinkAction },
+}
+
+impl From<wysiwyg::LinkActionUpdate<Utf16String>> for LinkActionUpdate {
+    fn from(inner: wysiwyg::LinkActionUpdate<Utf16String>) -> Self {
+        match inner {
+            wysiwyg::LinkActionUpdate::Keep => Self::Keep,
+            wysiwyg::LinkActionUpdate::Update(action) => Self::Update {
+                link_action: action.into(),
+            },
+        }
+    }
+}

crates/wysiwyg/src/composer_model/base.rs

@@ -19,6 +19,7 @@ use crate::dom::parser::markdown::markdown_html_parser::MarkdownHTMLParser;
 use crate::dom::parser::parse;
 use crate::dom::to_plain_text::ToPlainText;
 use crate::dom::{Dom, DomCreationError, UnicodeString};
+use crate::link_action::LinkActionUpdate;
 use crate::{
     ComposerAction, ComposerUpdate, DomHandle, Location, ToHtml, ToMarkdown,
     ToTree,
@@ -156,6 +157,7 @@ where
             self.state.end,
             menu_state,
             self.compute_menu_action(),
+            LinkActionUpdate::Update(self.get_link_action()),
         )
     }
 
@@ -169,6 +171,7 @@ where
             self.state.end,
             self.compute_menu_state(MenuStateComputeType::KeepIfUnchanged),
             self.compute_menu_action(),
+            LinkActionUpdate::Update(self.get_link_action()),
         )
     }
 
@@ -184,6 +187,7 @@ where
             self.state.end,
             self.compute_menu_state(MenuStateComputeType::AlwaysUpdate),
             self.compute_menu_action(),
+            LinkActionUpdate::Update(self.get_link_action()),
         )
     }
 

crates/wysiwyg/src/composer_model/replace_text.rs

@@ -241,11 +241,13 @@ mod test {
     use widestring::Utf16String;
 
     use crate::action_state::ActionState;
+    use crate::link_action::LinkActionUpdate;
     use crate::menu_state::MenuStateUpdate;
     use crate::tests::testutils_composer_model::cm;
     use crate::tests::testutils_conversion::utf16;
     use crate::{
-        ComposerAction, ComposerUpdate, Location, MenuAction, MenuState,
+        ComposerAction, ComposerUpdate, LinkAction, Location, MenuAction,
+        MenuState,
     };
     use strum::IntoEnumIterator;
 
@@ -263,6 +265,7 @@ mod test {
                     action_states: indent_unindent_redo_disabled()
                 }),
                 MenuAction::None,
+                LinkActionUpdate::Update(LinkAction::CreateWithText),
             ),
         );
     }

crates/wysiwyg/src/composer_update.rs

@@ -13,6 +13,7 @@
 // limitations under the License.
 
 use crate::dom::UnicodeString;
+use crate::link_action::LinkActionUpdate;
 use crate::{
     Location, MenuAction, MenuState, ReplaceAll, Selection, TextUpdate,
 };
@@ -25,6 +26,7 @@ where
     pub text_update: TextUpdate<S>,
     pub menu_state: MenuState,
     pub menu_action: MenuAction,
+    pub link_action: LinkActionUpdate<S>,
 }
 
 impl<S> ComposerUpdate<S>
@@ -36,6 +38,7 @@ where
             text_update: TextUpdate::<S>::Keep,
             menu_state: MenuState::Keep,
             menu_action: MenuAction::Keep,
+            link_action: LinkActionUpdate::Keep,
         }
     }
 
@@ -47,6 +50,7 @@ where
             text_update: TextUpdate::<S>::Keep,
             menu_state,
             menu_action,
+            link_action: LinkActionUpdate::Keep,
         }
     }
 
@@ -55,11 +59,13 @@ where
         end: Location,
         menu_state: MenuState,
         menu_action: MenuAction,
+        link_action: LinkActionUpdate<S>,
     ) -> Self {
         Self {
             text_update: TextUpdate::<S>::Select(Selection { start, end }),
             menu_state,
             menu_action,
+            link_action,
         }
     }
 
@@ -69,6 +75,7 @@ where
         end: Location,
         menu_state: MenuState,
         menu_action: MenuAction,
+        link_action: LinkActionUpdate<S>,
     ) -> Self {
         Self {
             text_update: TextUpdate::ReplaceAll(ReplaceAll {
@@ -78,6 +85,7 @@ where
             }),
             menu_state,
             menu_action,
+            link_action,
         }
     }
 }

crates/wysiwyg/src/lib.rs

@@ -48,6 +48,7 @@ pub use crate::dom::UnicodeString;
 pub use crate::dom::{MarkdownError, ToMarkdown};
 pub use crate::format_type::InlineFormatType;
 pub use crate::link_action::LinkAction;
+pub use crate::link_action::LinkActionUpdate;
 pub use crate::list_type::ListType;
 pub use crate::location::Location;
 pub use crate::menu_action::MenuAction;

crates/wysiwyg/src/link_action.rs

@@ -14,7 +14,13 @@
 
 use crate::UnicodeString;
 
-#[derive(Debug, PartialEq, Eq)]
+#[derive(Clone, Debug, PartialEq, Eq)]
+pub enum LinkActionUpdate<S: UnicodeString> {
+    Keep,
+    Update(LinkAction<S>),
+}
+
+#[derive(Clone, Debug, PartialEq, Eq)]
 pub enum LinkAction<S: UnicodeString> {
     CreateWithText,
     Create,

platforms/android/library-compose/src/androidTest/java/io/element/android/wysiwyg/compose/RichTextEditorTest.kt

@@ -8,10 +8,12 @@ import androidx.test.espresso.assertion.ViewAssertions.matches
 import androidx.test.espresso.matcher.ViewMatchers.isDisplayed
 import androidx.test.espresso.matcher.ViewMatchers.withText
 import io.element.android.wysiwyg.compose.testutils.ComposerActions.DEFAULT_ACTIONS
+import io.element.android.wysiwyg.compose.testutils.EditorActions
 import io.element.android.wysiwyg.compose.testutils.StateFactory.createState
 import io.element.android.wysiwyg.compose.testutils.ViewMatchers.isRichTextEditor
 import io.element.android.wysiwyg.compose.testutils.copy
 import io.element.android.wysiwyg.compose.testutils.showContent
+import io.element.android.wysiwyg.view.models.LinkAction
 import kotlinx.coroutines.test.runTest
 import org.junit.Assert.assertEquals
 import org.junit.Rule
@@ -128,4 +130,26 @@ class RichTextEditorTest {
         assertEquals("Hello, <a href=\"https://matrix.org\">element</a>", state.messageHtml)
         assertEquals("Hello, [element](<https://matrix.org>)", state.messageMarkdown)
     }
+
+    @Test
+    fun testLinkActionUpdates() = runTest {
+        val state = createState()
+        composeTestRule.showContent(state)
+
+        composeTestRule.runOnUiThread {
+            state.setHtml("<a href=\"https://matrix.org\">matrix</a> <a href=\"https://element.io\">element</a> plain")
+        }
+
+        onView(withText("matrix element plain")).perform(EditorActions.setSelection(0, 0))
+        assertEquals(LinkAction.SetLink("https://matrix.org"), state.linkAction)
+
+        onView(withText("matrix element plain")).perform(EditorActions.setSelection(8, 8))
+        assertEquals(LinkAction.SetLink("https://element.io"), state.linkAction)
+
+        onView(withText("matrix element plain")).perform(EditorActions.setSelection(16, 16))
+        assertEquals(LinkAction.InsertLink, state.linkAction)
+
+        onView(withText("matrix element plain")).perform(EditorActions.setSelection(16, 20))
+        assertEquals(LinkAction.SetLink(null), state.linkAction)
+    }
 }

platforms/android/library-compose/src/androidTest/java/io/element/android/wysiwyg/compose/testutils/EditorActions.kt

@@ -0,0 +1,29 @@
+package io.element.android.wysiwyg.compose.testutils
+
+import android.view.View
+import androidx.appcompat.widget.AppCompatEditText
+import androidx.test.espresso.UiController
+import androidx.test.espresso.ViewAction
+import androidx.test.espresso.matcher.ViewMatchers.isDisplayed
+import org.hamcrest.Matcher
+
+object Editor {
+    class SetSelection(
+        private val start: Int,
+        private val end: Int,
+    ) : ViewAction {
+        override fun getConstraints(): Matcher<View> = isDisplayed()
+
+        override fun getDescription(): String = "Set selection to $start, $end"
+
+        override fun perform(uiController: UiController?, view: View?) {
+            val editor = view as? AppCompatEditText ?: return
+            editor.setSelection(start, end)
+        }
+    }
+
+}
+
+object EditorActions {
+    fun setSelection(start: Int, end: Int) = Editor.SetSelection(start, end)
+}

platforms/android/library-compose/src/main/java/io/element/android/wysiwyg/compose/RichTextEditor.kt

@@ -81,6 +81,9 @@ private fun RealEditor(
                 menuActionListener = EditorEditText.OnMenuActionChangedListener { menuAction ->
                     state.menuAction = menuAction
                 }
+                linkActionChangedListener = EditorEditText.OnLinkActionChangedListener { linkAction ->
+                    state.linkAction = linkAction
+                }
                 onFocusChangeListener =
                     View.OnFocusChangeListener { _, hasFocus -> state.hasFocus = hasFocus }
 
@@ -89,7 +92,6 @@ private fun RealEditor(
                     state.messageHtml = getContentAsMessageHtml()
                     state.messageMarkdown = getMarkdown()
                     state.lineCount = lineCount
-                    state.linkAction = getLinkAction()
                 }
 
                 applyDefaultStyle()

platforms/android/library/src/main/java/io/element/android/wysiwyg/EditorEditText.kt

@@ -106,6 +106,10 @@ class EditorEditText : AppCompatEditText {
         fun onMenuActionChanged(menuAction: MenuAction)
     }
 
+    fun interface OnLinkActionChangedListener {
+        fun onLinkActionChanged(linkAction: LinkAction?)
+    }
+
     /**
      * Set the mention display handler to display mentions in a custom way.
      */
@@ -131,6 +135,18 @@ class EditorEditText : AppCompatEditText {
             }
         }
 
+    /**
+     * Set the link action listener to be notified when the available link action changes.
+     */
+    var linkActionChangedListener: OnLinkActionChangedListener? = null
+        set(value) {
+            field = value
+
+            viewModel.linkActionCallback = { linkAction ->
+                value?.onLinkActionChanged(linkAction)
+            }
+        }
+
     /**
      * When not null, it will serve as an error callback for the client integrating this lib.
      */

platforms/android/library/src/main/java/io/element/android/wysiwyg/internal/view/models/LinkActionExt.kt

@@ -0,0 +1,13 @@
+package io.element.android.wysiwyg.internal.view.models
+
+
+import io.element.android.wysiwyg.view.models.LinkAction
+import uniffi.wysiwyg_composer.LinkAction as InternalLinkAction
+
+internal fun InternalLinkAction.toApiModel(): LinkAction? =
+    when (this) {
+        is InternalLinkAction.Edit -> LinkAction.SetLink(currentUrl = url)
+        is InternalLinkAction.Create -> LinkAction.SetLink(currentUrl = null)
+        is InternalLinkAction.CreateWithText -> LinkAction.InsertLink
+        is InternalLinkAction.Disabled -> null
+    }