add-privileged-users-in-room

[GoodGuyMarco]

Jira-Ticket: https://element-io.atlassian.net/browse/PSB-169
Related PR: matrix-org/matrix-js-sdk#2892.

Adds a new section under "Room Settings" > "Roles & Permissions" which adds the possibility to multiselect users from this room and grant them more permissions.

When searching users via the new AutocompleteInput component, suggestions are shown and can be selected. Select a power level and hit the "Apply" button to confirm your changes. Users should appear in the "Privileged Users" section afterwards.

Checklist

• Tests written for new code (and old code if feasible)
• Linter and other CI checks pass
• Sign-off given on the changes (see CONTRIBUTING.md)

Notes: Adds a new section under "Room Settings" > "Roles & Permissions" which adds the possibility to multiselect users from this room and grant them more permissions.

element-web notes: Adds a new section under "Room Settings" > "Roles & Permissions" which adds the possibility to multiselect users from this room and grant them more permissions.

Signed-off-by: Marco Bartelt [email protected]

---

Here's what your changelog entry will look like:

✨ Features

• Adds a new section under "Room Settings" > "Roles & Permissions" which adds the possibility to multiselect users from this room and grant them more permissions. (#9596). Contributed by @GoodGuyMarco.

[jakewb-b]

Per the discussion in the PS Design room, just adding my review to confirm this was pre-discussed with us and, from the product POV, I'm happy with the proposed change.

[t3chguy]

@jakewb-b could you get a designer tasked with reviewing it?

[jakewb-b]

@jakewb-b could you get a designer tasked with reviewing it?

Yup - already been flagged to @gaelledel who was also involved in the original discussions on this.

[germain-gg]

Thank you for opening this pull request!
I've added a few comments that would need to be adressed before this can be merged in. There's also a few issue in regards to TypeScript strict mode that have been picked up by our CI that would need your attention.

I have not yet checked the tests you added, but will do once the rest of the code reaches it's more final shape

[GoodGuyMarco]

Hey @gsouquet, thank you for your constructive feedback! I tried to address all of your comments. Some of them were fixable, others need your feedback.

Could you help me regarding the TypeScript strict mode issue? Yesterday it showed me only errors in my changed files. Today it gives me 600 > errors, which is confusing. Maybe I could solve it with a rebase, but I'm not sure. Anyway it is not really convenient that I am not able to run this check locally like the Linters because that heavily increases the time spend on the feedback loop. Any ideas?

[germain-gg]

Thanks for adressing the feedback, a few minor things here. But this is definitely on the right track!
Next step would be to get a review from design.

A rebase with develop should help with CI going a bit crazy with the TS issues. If you want to test this locally, you can enable strict: true in tsconfig.json temporarily

[germain-gg]

needs to be updated, waiting on @matrix-org/design input

[GoodGuyMarco]

@gsouquet Hey, I've just rebased against develop and addressed your second feedback loop last week. Could you have another look and ask for the design feedback?

[gaelledel]

looks good to me thanks!

[germain-gg]

Code looks good to me, there are still some design outstanding question for @gaelledel before we can merge this.

[gaelledel]

Apologies, I did not notice a few details earlier.

1. For the search users field: We need to add a proper search field component with the Search icon and the following string "Search users"
2. Search users field: As soon as the user clicks in the field, we should display results in the drop down. Currently it doesn't show anything
3. Search field select colour should be set to Quarternary
4. When selecting "custom level" and clicking away from the fields it doesn't deselect the option which as a user does not allow me to rectify my choice to change a permission. No matter what I do, the Custom level is set to changeable numbers and does not give me the ability to change to another permission type

[GoodGuyMarco]

Thank you for your feedback @gaelledel. I have a few questions, as speaking about visuals always leaves room for misunderstanding.

1. For the search users field: We need to add a proper search field component with the Search icon and the following string "Search users"

1. By "...search field component with the search icon..." you mean that the input should have a magnifier icon on the left side (like in the screenshot)?

💡 Answer from Gaelle in 1:1 meeting: Yes, add a magnifier icon on the left. There a other places in the app this is missing.

2. By "...and the following string "Search users"..." you want to replace the placeholder I suggested Search users in this room... by Search users, correct?

💡 Answer from Gaelle in 1:1 meeting: "Search users in this room ..." is okay, just remove the space between room and the 3 dots.

---

2. Search users field: As soon as the user clicks in the field, we should display results in the drop down. Currently it doesn't show anything

Currently it displays results (matching your search criteria) as soon as you start typing. Why do we think that it should appear right away and what are your expectations if we change that regarding following questions:

1. How many results should appear when the room has many users. Should there be a maximum and what should it be?
2. Which users should appear first when there is no search criteria?

💡 Answer from Gaelle in 1:1 meeting: It would be nice if we could display a maximum of 5 suggestions immediately if that is possible, but that is no blocker if it is too complicated.

---

3. Search field select colour should be set to Quarternary

Do you mean the background color of a selected suggestion?

---

4. When selecting "custom level" and clicking away from the fields it doesn't deselect the option which as a user does not allow me to rectify my choice to change a permission. No matter what I do, the Custom level is set to changeable numbers and does not give me the ability to change to another permission type

Do you mean the the user is "trapped" inside the "custom level" input and can't go back to the select field? This is actually the current behaviour of this component. I stumbled across this aswell, but would suggest not changing this in my PR as it seems unrelated and deserves another issue.

💡 Answer from Gaelle in 1:1 meeting: We agreed that this is a major usability issue we should fix with high priority but not in this contribution. We will file another issue to fix that.