Skip to content
This repository has been archived by the owner on Sep 11, 2024. It is now read-only.

Live location sharing - update beacon_info implementation to latest MSC #8256

Merged
merged 8 commits into from
Apr 8, 2022

Conversation

kerryarchibald
Copy link
Contributor

@kerryarchibald kerryarchibald commented Apr 7, 2022

With: matrix-org/matrix-js-sdk#2281

Update beacon implementation to latest edition of matrix-org/matrix-js-sdk#2281


This change is marked as an internal change (Task), so will not be included in the changelog.

Preview: https://pr8256--matrix-react-sdk.netlify.app
⚠️ Do you trust the author of this PR? Maybe this build will steal your keys or give you malware. Exercise caution. Use test accounts.

Kerry Archibald added 8 commits April 7, 2022 19:16
Signed-off-by: Kerry Archibald <[email protected]>
Signed-off-by: Kerry Archibald <[email protected]>
Signed-off-by: Kerry Archibald <[email protected]>
Signed-off-by: Kerry Archibald <[email protected]>
Signed-off-by: Kerry Archibald <[email protected]>
Signed-off-by: Kerry Archibald <[email protected]>
@kerryarchibald kerryarchibald added the T-Task Refactoring, enabling or disabling functionality, other engineering tasks label Apr 7, 2022
@kerryarchibald kerryarchibald requested a review from a team as a code owner April 7, 2022 19:14
@codecov
Copy link

codecov bot commented Apr 7, 2022

Codecov Report

Merging #8256 (ef77bde) into develop (2332785) will increase coverage by 0.00%.
The diff coverage is 85.00%.

@@           Coverage Diff            @@
##           develop    #8256   +/-   ##
========================================
  Coverage    28.60%   28.60%           
========================================
  Files          861      861           
  Lines        49761    49769    +8     
  Branches     12674    12675    +1     
========================================
+ Hits         14232    14237    +5     
- Misses       35529    35532    +3     
Impacted Files Coverage Δ
src/components/views/location/shareLocation.ts 84.84% <ø> (ø)
src/stores/OwnBeaconStore.ts 96.19% <75.00%> (-1.56%) ⬇️
...c/components/views/beacon/RoomLiveShareWarning.tsx 98.61% <100.00%> (+0.03%) ⬆️
src/utils/beacon/duration.ts 100.00% <100.00%> (ø)

Copy link
Member

@turt2live turt2live left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks like an architecture change

@kerryarchibald kerryarchibald merged commit 03d0969 into develop Apr 8, 2022
@kerryarchibald kerryarchibald deleted the psf-879/beacon-use-msc3672 branch April 8, 2022 08:53
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
T-Task Refactoring, enabling or disabling functionality, other engineering tasks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants