Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Live location sharing - update beacon_info implementation to latest MSC #2281

Merged
merged 14 commits into from
Apr 8, 2022
Merged

Live location sharing - update beacon_info implementation to latest MSC #2281

merged 14 commits into from
Apr 8, 2022

Conversation

kerryarchibald
Copy link
Contributor

@kerryarchibald kerryarchibald commented Apr 7, 2022 •
edited by github-actions bot
Loading

matrix-org/matrix-spec-proposals#3672

  • changes unstable event prefixes to use msc3672
  • changes beacon identifier logic. Previously beacons used unique event types to enable multiple state events per user per room so event type could be used as an identifier. According to msc3672 plain event types and state_key are used for beacons, identifier is now <roomId>_<state_key>.
  • add extra logic about beacon update

This change is marked as an internal change (Task), so will not be included in the changelog.

Kerry Archibald added 14 commits April 7, 2022 18:46
remove M_BEACON_INFO_VARIABLE
bb3585e 
Signed-off-by: Kerry Archibald <[email protected]>
create beacon_info events with non-variable event type
19c9ccf 
Signed-off-by: Kerry Archibald <[email protected]>
remove isBeaconInfoEventType
027a4ad 
Signed-off-by: Kerry Archibald <[email protected]>
refer to msc3673 instead of msc3489
d8cf35e 
Signed-off-by: Kerry Archibald <[email protected]>
remove event type suffix
cfc3c55 
Signed-off-by: Kerry Archibald <[email protected]>
update beacon identifier to use state key
59a022f 
Signed-off-by: Kerry Archibald <[email protected]>
fix beacon spec
220ae74 
Signed-off-by: Kerry Archibald <[email protected]>
fix room-state tests
8d6241e 
Signed-off-by: Kerry Archibald <[email protected]>
add beacon identifier
271a174 
Signed-off-by: Kerry Archibald <[email protected]>
dont allow update to older beacon event
f09f364 
Signed-off-by: Kerry Archibald <[email protected]>
lint
55bada7 
Signed-off-by: Kerry Archibald <[email protected]>
unnest beacon_info content
5cd642a 
Signed-off-by: Kerry Archibald <[email protected]>
lint
ac5f965 
Signed-off-by: Kerry Archibald <[email protected]>
check redaction event id
1f7c51b 
Signed-off-by: Kerry Archibald <[email protected]>
@kerryarchibald kerryarchibald added the T-Task Tasks for the team like planning label Apr 7, 2022
@kerryarchibald kerryarchibald requested a review from a team as a code owner April 7, 2022 19:12
@kerryarchibald kerryarchibald mentioned this pull request Apr 7, 2022
Merged
turt2live
turt2live approved these changes Apr 8, 2022
View reviewed changes
spec/test-utils/beacon.ts
@@ -51,12 +50,14 @@ export const makeBeaconInfoEvent = (
...contentProps,
};
const event = new MatrixEvent({
type: `${M_BEACON_INFO.name}.${sender}.${eventTypeSuffix || Date.now()}`,
type: M_BEACON_INFO.name,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@kerryarchibald kerryarchibald merged commit 781fdf4 into develop Apr 8, 2022
@kerryarchibald kerryarchibald deleted the psf-879/beacon-use-msc3672 branch April 8, 2022 08:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@turt2live turt2live turt2live approved these changes

Assignees
No one assigned
Labels
T-Task Tasks for the team like planning
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kerryarchibald @turt2live