This repository has been archived by the owner on Sep 11, 2024. It is now read-only.
[WIP] Make layout compatible with RTL languages #8217
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses element-hq/element-web#14520
Requires #8230 #8231 #8243
This PR intends to make the current style rules written for the LTR (Left-To-Right) layout compatible with the RTL (Right-To-Left) layout, in order to make it possible to display UI in RTL languages such as Hebrew properly. Currently, UI in these languages are displayed in the LTR layout, but it should display not only translated strings but also other elements such as icons, buttons, the sidebar, the panel etc. from right to left, according to its layout.
Currently I don't plan to implement a function to enable the RTL layout as it is beyond my capability. The layout should be able to be switched by changing the value of
dir
specified to the tophtml
tag. Any help to implement it is greatly appreciated!float: right
andfloat: left
used to align elements with flex/grid, which takes care of the flow of the elements automaticallyTodo:
Right*
andLeft*
eg.mx_RightPanel
right
andleft
(with margin, padding, float, etc.) should be avoided to maintain the RTL compatibilitySteps to test locally:
dir="rtl"
tohtml
tag ofsrc/vector/index.html
insideelement-web
yarn start
Peek.2022-04-03.09-10.mp4
Here's what your changelog entry will look like:
✨ Features
Preview: https://pr8217--matrix-react-sdk.netlify.app
⚠️ Do you trust the author of this PR? Maybe this build will steal your keys or give you malware. Exercise caution. Use test accounts.