-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RTL Support #14520
Comments
It would help if you expressed what the specific issues with RTL were, the app specifies https://developer.mozilla.org/en-US/docs/Web/HTML/Global_attributes/dir in a lot of places so there should be broad support. |
Related #1712 |
The issue seems to be that elements are currently placed based on styles for LTR. Menus, buttons, strings, etc. should be placed from left to right as well. See https://he.wikipedia.org/ for example. RTL layout itself can be enabled easily by adding Also, the close button is not expected to be placed before the title of the dialog: This case either including the button element inside a flexbox or styling with If full RTL support is in scope, it might be worth changing styles to be applicable for both LTR and RTL layouts gradually. A module to take care of the convert should be appreciated. |
For the concept, please check https://github.com/luixxiul/matrix-react-sdk/tree/rtl. There are tons of glitches and conflicts to be sorted. To try the design, you need to add after.mp4Peek.2022-04-03.09-10.mp4With CSS logical properties like |
@t3chguy would you let me know what you would think about this? Could I work on modifying the styles related to this, including fixing bugs such as the close button covering the dialog's title? The biggest problem here is that it would be no longer recommended to use something like |
Hi. I'm also being affected by this bug and would like to help get it resolved if I can. From the discussions here and elsewhere it seems that a lot of CSS work is required to get this fixed in one go. To make resolving this issue more manageable, I would like to suggest that we break apart this issue into two smaller issues since interface directionality and content directionality are separate and can be fixed separately; i.e. RTL messages should still appear correctly in LTR-only interfaces and vice versa.
It has been a couple of years since I worked with bidi layouts. I've also never contributed to a third-party open-source project on GitHub before, but I'm willing to help if I can. Thoughts? |
Would it make sense to reopen #4771 and dedicate it to the issue of content directionality leaving this to interface directionality? |
I posted this comment in issue 4771 and wanted to post it here since it's relevant to this issue as well. Apologies for the overhead.
|
Would it be possible to increase font size of persian and arabic writting. |
matrix-org/matrix-react-sdk#12837 was merged which made the same change as matrix-org/matrix-react-sdk#5453 and that PR was marked as fixing this issue, so I'm going to close this, (which isn't to say our RTL support is now perfect, but more issues welcome for any more specific things). |
Is your suggestion related to a problem? Please describe.
As you may know the Arabic/Persian alphabet are in reverse format compared with English , I mean if you write things from left to right ... in Persian you must write from right to left
Describe the solution you'd like
you could add RTL (right to left ) support
Describe alternatives you've considered
for i.e you can see microsoft office , it has RTL support too in text formating section
Additional context
Thanks , It would be great .
Please add this feature in Riot Desktop too .
The text was updated successfully, but these errors were encountered: