Skip to content
This repository has been archived by the owner on Sep 11, 2024. It is now read-only.

Fixes the padding to make the border of invite link visible #7966

Closed
wants to merge 3 commits into from
Closed

Fixes the padding to make the border of invite link visible #7966

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d96a861
Fixes vector-im/element-web/issues/20911
archijaiswal Mar 3, 2022
137d468
Merge remote-tracking branch 'upstream/develop' into padding-on-dialo…
archijaiswal Mar 3, 2022
fac746b
Fixed the Footer's height
archijaiswal Mar 4, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion res/css/views/elements/_CopyableText.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ limitations under the License.
border: solid 1px $light-fg-color;
margin-bottom: 10px;
margin-top: 10px;
padding: 10px;
padding: 9px;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

9px is a bit of a weird value in our code (we typically stick to multiples of 2 or 4, or at least even numbers) - can this get a comment for why it's a bit different?

More generally though, I'm concerned that this doesn't fix the issue for the future. The dialog should be able to handle additional padding, implying something is going wrong in the dialog's CSS rather than here, I think.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, alright. Thank you so much for your kind review. I'll surely keep these things in mind and try to come up with a better fix.
(Nothing so specific for 9px since it was the minimum modification I could think of to fix this. Thanks for your direction!)

width: max-content;
max-width: 100%;

Expand Down