Fixes the padding to make the border of invite link visible

[archijaiswal]

Fixes element-hq/element-web/issues/20911

Modified the padding on dialog button to make the border of invite link visible.

How it looked before

How it looks now

Signed-off-by: Archi Jaiswal [email protected]

---

Here's what your changelog entry will look like:

🐛 Bug Fixes

• Fixes the padding to make the border of invite link visible (#7966). Contributed by @archijaiswal.

Preview: https://pr7966--matrix-react-sdk.netlify.app
⚠️ Do you trust the author of this PR? Maybe this build will steal your keys or give you malware. Exercise caution. Use test accounts.

[SimonBrandner]

@archijaiswal, could you please rename the PR to something more understandable (e.g. Fix the padding in invite dialog...) and merge and push the latest change in the js-sdk to your fork? It should fix the type checks

Thanks

[turt2live]

thanks for taking a look at this! As mentioned in the thread, I'm somewhat concerned that the issue is a bit more involved than just fixing padding - if you have more information about how the dialog is behaving to cause the issue, that would be appreciated.

[turt2live]

9px is a bit of a weird value in our code (we typically stick to multiples of 2 or 4, or at least even numbers) - can this get a comment for why it's a bit different?

More generally though, I'm concerned that this doesn't fix the issue for the future. The dialog should be able to handle additional padding, implying something is going wrong in the dialog's CSS rather than here, I think.

[archijaiswal]

Oh, alright. Thank you so much for your kind review. I'll surely keep these things in mind and try to come up with a better fix.
(Nothing so specific for 9px since it was the minimum modification I could think of to fix this. Thanks for your direction!)

[archijaiswal]

Please review this @turt2live , 1px was causing this issue.

Thanks

[luixxiul]

I am wondering why removing overflow: hidden from .mx_InviteDialog_content would not work instead.

[archijaiswal]

Actually, that was unnecessarily adding a scroll bar as it's height is fixed. @luixxiul

[luixxiul]

Actually, that was unnecessarily adding a scroll bar as it's height is fixed. @luixxiul

This is what I see by removing the overflow property. Maybe on my side only?

The overflow has been added here (based on here) related to dialpad improvements, so not sure if it could be safely removed.

[turt2live]

argh, I forgot that there was a PR already open for this.

Like in my other review, I think this is a more general problem than the invite dialog: #8165 (review)

[turt2live]

It appears as though the bug which caused this has been fixed - thanks for the PR in any case :)