This repository has been archived by the owner on Sep 11, 2024. It is now read-only.
Add confirmation dialog to kick/ban buttons #694
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,83 @@ | ||
| /* | ||
| Copyright 2017 Vector Creations Ltd | ||
|
|
||
| Licensed under the Apache License, Version 2.0 (the "License"); | ||
| you may not use this file except in compliance with the License. | ||
| You may obtain a copy of the License at | ||
|
|
||
| http://www.apache.org/licenses/LICENSE-2.0 | ||
|
|
||
| Unless required by applicable law or agreed to in writing, software | ||
| distributed under the License is distributed on an "AS IS" BASIS, | ||
| WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| See the License for the specific language governing permissions and | ||
| limitations under the License. | ||
| */ | ||
|
|
||
| import React from 'react'; | ||
| import sdk from '../../../index'; | ||
| import classnames from 'classnames'; | ||
|
|
||
| /* | ||
| * A dialog for confirming an operation on another user. | ||
| * Takes a user ID and a verb, displays the target user prominently | ||
| * such that it should be easy to confirm that tne operation is being | ||
| * performed on the right person, and displays the operation prominently | ||
| * to make it obvious what is going to happen. | ||
| * Also tweaks the style for 'dangerous' actions (albeit only with colour) | ||
| */ | ||
| export default React.createClass({ | ||
| displayName: 'ConfirmUserActionDialog', | ||
| propTypes: { | ||
| member: React.PropTypes.object.isRequired, // member object | ||
|
There was a problem hiding this comment. Could use There was a problem hiding this comment. Thought about it, although it's a standard JS SDK member object. There was a problem hiding this comment. oh ok.. I wished there was a thing for this but I don't think there is... maybe change the comment so that it's obvious that There was a problem hiding this comment. oh.. you did that, in that case LGTM |
||
| action: React.PropTypes.string.isRequired, // eg. 'Ban' | ||
| danger: React.PropTypes.bool, | ||
| onFinished: React.PropTypes.func.isRequired, | ||
| }, | ||
|
|
||
| defaultProps: { | ||
| danger: false, | ||
| }, | ||
|
|
||
| onOk: function() { | ||
| this.props.onFinished(true); | ||
| }, | ||
|
|
||
| onCancel: function() { | ||
| this.props.onFinished(false); | ||
| }, | ||
|
|
||
| render: function() { | ||
| const BaseDialog = sdk.getComponent('views.dialogs.BaseDialog'); | ||
| const MemberAvatar = sdk.getComponent("views.avatars.MemberAvatar"); | ||
|
|
||
| const title = this.props.action + " this person?"; | ||
| const confirmButtonClass = classnames({ | ||
| 'mx_Dialog_primary': true, | ||
| 'danger': this.props.danger, | ||
| }); | ||
| return ( | ||
| <BaseDialog className="mx_UserActionConfirmDialog" onFinished={this.props.onFinished} | ||
| onEnterPressed={ this.onOk } | ||
| title={title} | ||
| > | ||
| <div className="mx_Dialog_content"> | ||
| <div className="mx_ConfirmUserActionDialog_avatar"> | ||
| <MemberAvatar member={this.props.member} width={72} height={72} /> | ||
| </div> | ||
| <div className="mx_ConfirmUserActionDialog_name">{this.props.member.name}</div> | ||
| <div className="mx_ConfirmUserActionDialog_userId">{this.props.member.userId}</div> | ||
| </div> | ||
| <div className="mx_Dialog_buttons"> | ||
| <button className={confirmButtonClass} onClick={this.onOk} autoFocus={true}> | ||
| {this.props.action} | ||
| </button> | ||
|
|
||
| <button onClick={this.onCancel}> | ||
| Cancel | ||
| </button> | ||
| </div> | ||
| </BaseDialog> | ||
| ); | ||
| }, | ||
| }); | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the